Skip to content

setup.py and pyproject.toml both exist and neither one correctly installs the core library #437

@avinxshKD

Description

@avinxshKD

two packaging configs sitting side by side, disagreeing on basically everything, and between them they still manage to not ship the actual library.

concore.py and concoredocker.py aren't declared as py-modules in either file. so pip install . + import concore outside the project dir = ModuleNotFoundError. that's the whole point of the package.

setup.py uses find_packages() which picks up tests/ and pycache/ as installable packages. pyproject.toml has an explicit list but it's missing concore_cli.commands. they don't agree on deps either, setup.py unversioned, pyproject.toml versioned. requirements.txt has tensorflow, cvxopt, PyGithub which nothing in the core library uses. demo deps that leaked in and now get pulled for everyone.

version 1.0.0 is hardcoded in both files separately.

fix can be, drop setup.py or make it a shim, add concore + concoredocker as py-modules in pyproject.toml, single-source the version, move the heavy demo deps to optional extras.

good starting point is just adding the missing py-modules to pyproject.toml ,, that alone fixes the broken install. rest is cleanup.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions