Using this in a nodeAPI

[pipje2001]

I am trying to get this module to work in a nodeAPI, so i can use the hue entertainment api in python via this api of mine, now i am kinda running into a lot of problems, mainly that the lights don't change color or do anything at all:

i have this connect function:

router.get('/connect', async (req, res) => {
  try {
    let options = {
      address: '192.168.1.233',
      username: 'oyCbaYTEWX9QJ1X4UJNp4LZIDPa0lA6TPuwXhzc9',
      psk: 'B1E654E9E1BD7D761CCD6841D590B94E'
    };
    running = true;
    bridge = await Phea.bridge(options);
    console.log(bridge);
    res.send('Connected');
  } catch (err) {
    console.error(err.message);
    res.status(500).send('Server Error');
  }
});

which works fine, i removed the let before the bridge = await Phea.bridge(options);, so it can be used in different fucntions

i got a start and a stop function, stop just runs brige.stop and stops the loop which is running in basicExample (your example):

async function basicExample() {
  let groupId = 5;
  let transitionTime = 1000; // milliseconds
  await bridge.start(groupId);

  while (running) {
    let color = [
      // Generate Random RGB Color Array
      Math.floor(55 + Math.random() * Math.floor(200)),
      Math.floor(55 + Math.random() * Math.floor(200)),
      Math.floor(55 + Math.random() * Math.floor(200))
    ];

    // Set all lights to random color.
    bridge.transition(0, color, transitionTime);
    console.log(color);

    // Sleep until next color update is needed.
    await new Promise(resolve => setTimeout(resolve, transitionTime));
  }
}

so bassically it does nothing whith the lights at all, it does change the stream to active, but doesn't change any lights.

[JakeBednard]

Hi Pipje, looking into this now. I think the issue is related to removing the async, which leads to a race condition whereas the DTLS socket trys to connect before {"stream": "active"}. But additionally, it may be the way that the library is interacting with your server library threading/context.

I like the idea of hiding the library behind an HTTP API. It is a nice way to main a home server. What web framework are using (ExpressJS?). In your case, is the bridge being created on a global or local context? You'll need the async's for now, and potentially need to keep the bridge object in the global context. If you can provide a larger gist, I may be able to point you in the correct direction.

Regarding async, I'm trying to reconcile with myself if this is a JS anti-pattern. Give me sometime tow/ think about this, but startup procedure code wise needs to be sequential (eventually safety can be built in):

1. Create bridge w/ Options dictionary object. Wait for return.
2. Send HTTP request to HTTP:80 requesting DTLS group enable. Wait for return.
3. Initialize DTLS Socket. (We need to this to block, but the code isn't fully there yet).
   3a. Launch DTLS messaging to keep socket alive.
4. Start streaming bridge.transition color changes.
5. When done, close DTLS connection. (Socket + HTTP).

[JakeBednard]

Another fun idea with this one: I wonder if this library can somehow be interfaced through WASM and imported directly into Python. I'd love this as a (usually) Python first dev. In fact, the reason this library is written in Node is that Node's cross-platform support for DTLS sockets was better at the time. I'm not sure if python has improved in this area.

[pipje2001]

I like the idea of hiding the library behind an HTTP API. It is a nice way to main a home server. What web framework are using (ExpressJS?). In your case, is the bridge being created on a global or local context? You'll need the async's for now, and potentially need to keep the bridge object in the global context. If you can provide a larger gist, I may be able to point you in the correct direction.

I am indeed using ExpressJS, the bridge is created as a global context otherwise the next time you send a request to the api it will not know what the bridge is. What do you mean with a larger gist?

[pipje2001]

Another fun idea with this one: I wonder if this library can somehow be interfaced through WASM and imported directly into Python. I'd love this as a (usually) Python first dev. In fact, the reason this library is written in Node is that Node's cross-platform support for DTLS sockets was better at the time. I'm not sure if python has improved in this area.

Nope python has not improved in this erea, the whole reason i am doing this with a nodeAPI is because python doesn't support this type of dtls connection

[JakeBednard]

Hey pipje, I just updated the library. #7 was a similar bug to yours and I was able to pinpoint a bug causing lights not to change when their IDs were not sequential starting at "1". Give it a try and let me know if it resolves your issue.

[JakeBednard]

Just made issue #8 to add functionality somehow (this library or child library) for an HTTP server version of this.

[pipje2001]

Hey pipje, I just updated the library. #7 was a similar bug to yours and I was able to pinpoint a bug causing lights not to change when their IDs were not sequential starting at "1". Give it a try and let me know if it resolves your issue.

Yep it fixed it so far!

Just made issue #8 to add functionality somehow (this library or child library) for an HTTP server version of this.

I will help with this if i have the time, but it should be to difficult

[pipje2001]

Alright i tested the basicExample which worked but when i try to do it via a http request from python the server trows this error:

(node:14372) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'transitionColor' of undefined
    at PheaEngine.<anonymous> (b:\NAS CloudStation\PC\Prive\visual_studio_code\GitHub\WOT-Huenify\Hue Entertainment API\nodeAPI\node_modules\phea\build\phea-engine.js:58:50)
    at Generator.next (<anonymous>)
    at b:\NAS CloudStation\PC\Prive\visual_studio_code\GitHub\WOT-Huenify\Hue Entertainment API\nodeAPI\node_modules\phea\build\phea-engine.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (b:\NAS CloudStation\PC\Prive\visual_studio_code\GitHub\WOT-Huenify\Hue Entertainment API\nodeAPI\node_modules\phea\build\phea-engine.js:4:12)
    at PheaEngine.transition (b:\NAS CloudStation\PC\Prive\visual_studio_code\GitHub\WOT-Huenify\Hue Entertainment API\nodeAPI\node_modules\phea\build\phea-engine.js:51:16)
    at lightId.forEach (b:\NAS CloudStation\PC\Prive\visual_studio_code\GitHub\WOT-Huenify\Hue Entertainment API\nodeAPI\node_modules\phea\build\hue-bridge.js:87:37)
    at Array.forEach (<anonymous>)
    at HueBridge.<anonymous> (b:\NAS CloudStation\PC\Prive\visual_studio_code\GitHub\WOT-Huenify\Hue Entertainment API\nodeAPI\node_modules\phea\build\hue-bridge.js:79:21)
    at Generator.next (<anonymous>)
(node:14372) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function 
without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:14372) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I connect to the bridge with this function, which works fine i think:

// Connect to the bridge
router.post('/connect', async (req, res) => {
  try {
    const { hubIP, userName, psk } = req.body;
    let options = {
      address: hubIP,
      username: userName,
      psk: psk
    };
    console.log(`Connecting with bridge on ${hubIP}`);
    bridge = await Phea.bridge(options);

    console.log('Connected');
    res.send('Connected');
  } catch (err) {
    console.error(err.message);
    res.status(500).send('Server Error');
  }a

i start the stream with:

router.get('/start', async (req, res) => {
  try {
    const { groupID } = req.body;
    await bridge.start(groupID);
    running = true;
    console.log('Started');
    res.send('Started');
  } catch (err) {
    console.error(err.message);
    res.status(500).send('Server Error');
  }
});

and send a stream like this:

router.post('/stream', async (req, res) => {
  try {
    const { lightID = 0, RGB, transitionTime = 1000 } = req.body;
    console.log(lightID, RGB, transitionTime);
    bridge.transition(lightID, RGB, transitionTime);
    console.log('Streamed');
    res.send('Streamed');
  } catch (err) {
    console.error(err.message);
    res.status(500).send('Server Error');
  }
});

somehow this doesn't work and the example does....

[JakeBednard]

ACK. I'll see if I can get this working when I have a moment. I need to play with Express to get a feel for the namespacing. The code looks fine, so I imagine that the application context is getting misplaced or that theres a race. Here is where the error is originating from:

    constructor(id, options) {
        this.id = id;
        this.opts = options;
        this.rgb = [0, 0, 0];
        this.gen = null;
        this.transitionColor([0, 0, 0], 0);
    }
    transitionColor(rgb, tweenTime) {
        this.gen = this.setTransition(rgb, tweenTime);
    }
...```

So it sounds like the constructor is calls this.transitionColor just fine, but the secondary call during the stream exchange, the lights are undefined. I'd have to look, but as long as the stream is active from bridge.start(groupId), lights should be defined. Hmm if its not a context issue, I wonder if the bridge closes at some point. Two action items from this as well for enhancing the libraries debugging:

1) Create a configState message on bridge to dump a dictionary of bridge state and configuration.
2) If socket is not open, retry to open or throw.

I'll let you know when I am able to test this out.

[pipje2001]

Just to be clear, it isn't nessecary to keep sending new messages to phea right?