Skip to content

Comments

Mark security issues as safe for security checks#293

Open
harminius wants to merge 4 commits intomasterfrom
qgis-security-scan
Open

Mark security issues as safe for security checks#293
harminius wants to merge 4 commits intomasterfrom
qgis-security-scan

Conversation

@harminius
Copy link
Contributor

@harminius harminius commented Feb 19, 2026

Py-client part to resolve MerginMaps/qgis-plugin#872

Flags used to tell security checks to skip the lines as they are safe.

More detail MerginMaps/qgis-plugin#875

@coveralls
Copy link

coveralls commented Feb 19, 2026

Pull Request Test Coverage Report for Build 22174282667

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 82.482%

Totals Coverage Status
Change from base Build 22054712002: 0.09%
Covered Lines: 4233
Relevant Lines: 5132

💛 - Coveralls

@varmar05
Copy link
Contributor

@harminius could you put commands you used for those check in description?

cursor.execute("COMMIT;")


def _delete_spatial_table(db_file):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused?

:return: sha1 checksum
"""
checksum = hashlib.sha1()
checksum = hashlib.sha1() # nosec B324 - usedforsecurity=False flag is compatible with python 3.9+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found 3.8 ... but I think it's still discussion, which python support. @tomasMizera


>>> origin = [{'checksum': '08b0e8caddafe74bf5c11a45f65cedf974210fed', 'path': 'base.gpkg', 'size': 2793, 'mtime': '2019-08-26T11:08:34.051221+02:00'}]
>>> current = [{'checksum': 'c9a4fd2afd513a97aba19d450396a4c9df8b2ba4', 'path': 'test.qgs', 'size': 31980, 'mtime': '2019-08-26T11:09:30.051221+02:00'}]
>>> origin = [{'checksum': '08b0e8caddafe74bf5c11a45f65cedf974210fed', 'path': 'base.gpkg', 'size': 2793, 'mtime': '2019-08-26T11:08:34.051221+02:00'}] # pragma: allowlist secret
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just remove this checksums and there "..." or foo text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Solve security scans issues in plugins.qgis

4 participants