Skip to content

Fullbright & BadOptimization Compatibility Issue #6083

@SnakyExotic

Description

@SnakyExotic

Describe the bug

Fullbright has a massive delay when using BadOptimizations, it probably has something to do with updating the lightmap that BadOptimization tries to fix. (this also occurs when using xray which uses fullbright.)

This can most likely be fixed with the implementation below:

Other mods can now add cache hooks that tell BadOptimizations when to update the lightmap/skycolor. See https://github.com/imthosea/BadOptimizations/wiki/Adding-lightmap-skycolor-caching-hooks
Add new config option "ignore_mod_cache_hooks" to ignore loading these hooks (not recommended)

Steps to reproduce

  1. Turn xray on with Badoptimizations
    link to mod: (https://modrinth.com/mod/badoptimizations)

Meteor Version

Meteor Client 1.21.11 build #46

Minecraft Version

MC 1.21.11

Operating System

Windows

Before submitting a bug report

  • This bug wasn't already reported (I have searched bug reports on GitHub).

  • This is a valid bug (I am able to reproduce this on the latest dev build).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions