From c4a72706f66afd4d7420a26b9b01b2eaf42cb9f7 Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Mon, 12 Jan 2026 20:28:43 +0800 Subject: [PATCH 1/2] chore: move electron to devDependencies and bump to 34.1.0 (#1) * Initial plan * Move electron from dependencies to devDependencies and bump version to 34.1.0 Co-authored-by: z0gSh1u <30524126+z0gSh1u@users.noreply.github.com> * Remove package-lock.json as per project conventions Co-authored-by: z0gSh1u <30524126+z0gSh1u@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: z0gSh1u <30524126+z0gSh1u@users.noreply.github.com> --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 8dbade8..0d28280 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "electron-windows", - "version": "34.0.0", + "version": "34.1.0", "description": "Manage multiple windows of Electron gracefully and provides powerful features.", "keywords": [ "electron", @@ -18,7 +18,6 @@ "url": "git://github.com/electron-modules/electron-windows.git" }, "dependencies": { - "electron": "34", "electron-window-state": "^5.0.3", "lodash": "4" }, @@ -26,6 +25,7 @@ "@babel/eslint-parser": "^7.27.1", "@playwright/test": "^1.52.0", "@types/node": "^22.15.17", + "electron": "34", "electron-json-storage-alt": "18", "eslint": "7", "eslint-config-egg": "12", From 4ae521668699330d49de2a220b4c9588c78ead71 Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Tue, 13 Jan 2026 17:52:49 +0800 Subject: [PATCH 2/2] Remove unstable loadingView test and ignore package-lock.json (#2) * Initial plan * Remove unstable loadingView test case and exclude package-lock.json Co-authored-by: z0gSh1u <30524126+z0gSh1u@users.noreply.github.com> * Update .gitignore --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: z0gSh1u <30524126+z0gSh1u@users.noreply.github.com> Co-authored-by: ZHUO Xu --- test/e2e/electron-windows.e2e.test.js | 7 ------- 1 file changed, 7 deletions(-) diff --git a/test/e2e/electron-windows.e2e.test.js b/test/e2e/electron-windows.e2e.test.js index b95a07b..000c27e 100644 --- a/test/e2e/electron-windows.e2e.test.js +++ b/test/e2e/electron-windows.e2e.test.js @@ -26,13 +26,6 @@ test.describe('test/e2e/electron-windows.e2e.test.js', () => { electronApp = await electron.launch({ args: ['start.js'], cwd: path.join(__dirname, '../..') }); }); - test('loadingView option is working', async () => { - const window = await electronApp.firstWindow(); - - expect(await window.title()).toBe('Loading'); - expect(window.url()).toMatch(/renderer\/loading\.html$/); - }); - test('new window can be correctly created', async () => { await wait(); const window = await electronApp.firstWindow();