Skip to content

Check my stuff I'm being controlled 😭 help #877

@moshms313-a11y

Description

@moshms313-a11y

Describe the bug

Help iam a beginner

Affected version

No response

Steps to reproduce the behavior

From 7dc078fd150c586f7664e99473768d0285777a31 Mon Sep 17 00:00:00 2001
From: Robert Sese 734194+rsese@users.noreply.github.com
Date: Thu, 21 Aug 2025 14:39:15 -0500
Subject: [PATCH 1/2] testing CI


.github/actions/node-npm-setup/action.yml | 6 ++++++
Dockerfile | 2 +-
package.json | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/.github/actions/node-npm-setup/action.yml b/.github/actions/node-npm-setup/action.yml
index fcc88e3d401e..7b007d961863 100644
--- a/.github/actions/node-npm-setup/action.yml
+++ b/.github/actions/node-npm-setup/action.yml
@@ -5,6 +5,12 @@ description: Will set up Node and install all packages by caching node_modules
runs:
using: 'composite'
steps:

  • Set this in GITHUB_ENV so it's set in the environment for users of this

  • action as a workaround for node 22.18 breaks npm package because of experimental-strip-types enabled nodejs/node#59364

    • name: Set -no-experimental-strip-types in NODE_OPTIONS
  •  shell: bash
    
  •  run: echo "NODE_OPTIONS=--no-experimental-strip-types" >> $GITHUB_ENV
    
    • name: Cache node_modules
      uses: actions/cache@v4
      id: cache-node_modules
      diff --git a/Dockerfile b/Dockerfile
      index 4fdcedbace2b..5a8c618aae2e 100644
      --- a/Dockerfile
      +++ b/Dockerfile
      @@ -18,7 +18,7 @@ FROM ghcr.io/github/gh-base-image/gh-base-noble:20250805-204228-g50c20871f AS ba

Must run as root

RUN apt-get -qq update && apt-get -qq install --no-install-recommends curl git
&& curl -sL https://deb.nodesource.com/setup_22.x | bash - \

  • && apt-get install -y nodejs=22.17.0-1nodesource1 \
  • && apt-get install -y nodejs
    && node --version

Create the node user and home directory

diff --git a/package.json b/package.json
index 4ef3a1398461..675f556ac274 100644
--- a/package.json
+++ b/package.json
@@ -328,7 +328,7 @@
"esm": "^3.2.25"
},
"engines": {

  • "node": "^20 || >=22.0.0 <22.18.0"
  • "node": "^20 || ^22"
    },
    "cacheDirectories": [
    "node_modules",

From 55768bb9d7f1914c3ca9ae1a13253881dabc1aaf Mon Sep 17 00:00:00 2001
From: Robert Sese 734194+rsese@users.noreply.github.com
Date: Thu, 21 Aug 2025 15:17:47 -0500
Subject: [PATCH 2/2] just set option in workflows env


.github/workflows/headless-tests.yml | 2 ++
.github/workflows/local-dev.yml | 1 +
2 files changed, 3 insertions(+)

diff --git a/.github/workflows/headless-tests.yml b/.github/workflows/headless-tests.yml
index 01d35526fb9e..bb089044280c 100644
--- a/.github/workflows/headless-tests.yml
+++ b/.github/workflows/headless-tests.yml
@@ -57,6 +57,8 @@ jobs:
- name: Run Playwright tests
env:
PLAYWRIGHT_WORKERS: ${{ fromJSON('[1, 4]')[github.repository == 'github/docs-internal'] }}

  •      NODE_OPTIONS: '--no-experimental-strip-types'
    
  •    # Run playwright rendering tests and a11y tests (axe scans) as distinct checks
       # so that we can run them without blocking merges until we can be confident
       # results for a11y tests are meaningul and scenarios we're testing are correct.
    

diff --git a/.github/workflows/local-dev.yml b/.github/workflows/local-dev.yml
index e706c212b12d..fffc0200ab05 100644
--- a/.github/workflows/local-dev.yml
+++ b/.github/workflows/local-dev.yml
@@ -50,6 +50,7 @@ jobs:
# by default failures are marked as "flaky" instead of "failed".
PLAYWRIGHT_RETRIES: 0
TEST_EARLY_ACCESS: ${{ github.repository == 'github/docs-internal' }}

  •      NODE_OPTIONS: '--no-experimental-strip-types'
       run: npm run playwright-test -- playwright-local-dev
    
     - name: Start server in the background
    

Expected behavior

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions