Since c31617f build fails on VS 2022 and VS 2026

[beinhaerter]

Describe the bug
The build of the test fails.

1> CMake generation started for configuration: 'clang-14-debug-clang-14-debug'.
1> Environment settings:
1>     CXXFLAGS=--target=amd64-pc-windows-msvc -fdiagnostics-absolute-paths
1>     CFLAGS=--target=amd64-pc-windows-msvc -fdiagnostics-absolute-paths
1>     CommandPromptType=Native
1>     DevEnvDir=C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\
1>     ExtensionSdkDir=C:\Program Files (x86)\Microsoft SDKs\Windows Kits\10\ExtensionSDKs
1>     EXTERNAL_INCLUDE=C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\include;C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\ATLMFC\include;C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Auxiliary\VS\include;C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt;C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\um;C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\shared;C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\winrt;C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\cppwinrt
1>     Framework40Version=v4.0
1>     FrameworkDir=C:\Windows\Microsoft.NET\Framework64\
1>     FrameworkDir64=C:\Windows\Microsoft.NET\Framework64\
1>     FrameworkVersion=v4.0.30319
1>     FrameworkVersion64=v4.0.30319
1>     IFCPATH=C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\ifc\x64
1>     INCLUDE=C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\include;C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\ATLMFC\include;C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Auxiliary\VS\include;C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt;C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\um;C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\shared;C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\winrt;C:\Program Files (x86)\Windows Kits\10\\include\10.0.26100.0\\cppwinrt
1>     LIB=C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\ATLMFC\lib\x64;C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\lib\x64;C:\Program Files (x86)\Windows Kits\10\lib\10.0.26100.0\ucrt\x64;C:\Program Files (x86)\Windows Kits\10\\lib\10.0.26100.0\\um\x64
1>     LIBPATH=C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\ATLMFC\lib\x64;C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\lib\x64;C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\lib\x86\store\references;C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.26100.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.26100.0;C:\Windows\Microsoft.NET\Framework64\v4.0.30319
1>     Path=C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\bin\HostX64\x64;C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\VC\VCPackages;C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer;C:\Program Files\Microsoft Visual Studio\2022\Professional\MSBuild\Current\bin\Roslyn;C:\Program Files (x86)\Microsoft Visual Studio\Shared\Common\VSPerfCollectionTools\vs2019\\x64;C:\Program Files (x86)\Microsoft Visual Studio\Shared\Common\VSPerfCollectionTools\vs2019\;C:\Program Files\Microsoft Visual Studio\2022\Professional\Team Tools\DiagnosticsHub\Collector;C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\\x64;C:\Program Files (x86)\Windows Kits\10\bin\\x64;C:\Program Files\Microsoft Visual Studio\2022\Professional\\MSBuild\Current\Bin\amd64;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\;C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\Tools\;C:\Program Files\Eclipse Adoptium\jre-8.0.472.8-hotspot\bin;C:\Program Files\Python314\Scripts\;C:\Program Files\Python314\;C:\Program Files\Python313\Scripts\;C:\Program Files\Python313\;C:\Program Files\Python312\Scripts\;C:\Program Files\Python312\;C:\Perl64\site\bin;C:\Perl64\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\AVMProgramme\oracle\oledb\bin;c:\AVMProgramme\oracle\ocl;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\dotnet\;C:\Program Files\WindowsPowerShell\Scripts\HP.ClientScriptLibrary;C:\Program Files\Azure Data Studio\bin;C:\Program Files\Git LFS;C:\Program Files\WinMerge;C:\Program Files (x86)\dotnet\;C:\Program Files\Microsoft SQL Server\150\Tools\Binn\;C:\Program Files\Graphviz\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\doxygen\bin;c:\Program Files\oracle\ocl;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Program Files\Git\cmd;C:\Program Files\PowerToys\DSCModules\;C:\WINDOWS\system32\config\systemprofile\AppData\Local\Microsoft\WindowsApps;C:\AVMProgramme\sonar\;C:\Users\whenze\AppData\Local\Programs\Python\Python39\Scripts\;C:\Users\whenze\AppData\Local\Programs\Python\Python39\;C:\Users\whenze\AppData\Local\Microsoft\WindowsApps;C:\Program Files (x86)\Qualcomm Atheros\Powerline Toolkit;C:\Program Files (x86)\Broadcom\l2command;C:\Users\whenze\source\powerline_tools\x64\Debug;C:\Users\whenze\AppData\Local\gitkraken\bin;%USERPROFILE%\AppData\Local\Microsoft\WindowsApps;;C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin;C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\CommonExtensions\Microsoft\CMake\Ninja;C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\VC\Linux\bin\ConnectionManagerExe
1>     PROMPT=$P$G
1>     UCRTVersion=10.0.26100.0
1>     UniversalCRTSdkDir=C:\Program Files (x86)\Windows Kits\10\
1>     VCIDEInstallDir=C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\VC\
1>     VCINSTALLDIR=C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\
1>     VCToolsInstallDir=C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.44.35207\
1>     VCToolsRedistDir=C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Redist\MSVC\14.44.35112\
1>     VCToolsVersion=14.44.35207
1>     VS170COMNTOOLS=C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\Tools\
1>     VSCMD_ARG_app_plat=Desktop
1>     VSCMD_ARG_HOST_ARCH=x64
1>     VSCMD_ARG_no_logo=1
1>     VSCMD_ARG_TGT_ARCH=x64
1>     VSCMD_DEBUG=5 
1>     VSCMD_VER=17.14.25
1>     VSINSTALLDIR=C:\Program Files\Microsoft Visual Studio\2022\Professional\
1>     WindowsLibPath=C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.26100.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.26100.0
1>     WindowsSdkBinPath=C:\Program Files (x86)\Windows Kits\10\bin\
1>     WindowsSdkDir=C:\Program Files (x86)\Windows Kits\10\
1>     WindowsSDKLibVersion=10.0.26100.0\
1>     WindowsSdkVerBinPath=C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\
1>     WindowsSDKVersion=10.0.26100.0\
1>     __DOTNET_ADD_64BIT=1
1>     __DOTNET_PREFERRED_BITNESS=64
1>     __VSCMD_PREINIT_PATH=C:\Program Files\Eclipse Adoptium\jre-8.0.472.8-hotspot\bin;C:\Program Files\Python314\Scripts\;C:\Program Files\Python314\;C:\Program Files\Python313\Scripts\;C:\Program Files\Python313\;C:\Program Files\Python312\Scripts\;C:\Program Files\Python312\;C:\Perl64\site\bin;C:\Perl64\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\AVMProgramme\oracle\oledb\bin;c:\AVMProgramme\oracle\ocl;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\dotnet\;C:\Program Files\WindowsPowerShell\Scripts\HP.ClientScriptLibrary;C:\Program Files\Azure Data Studio\bin;C:\Program Files\Git LFS;C:\Program Files\WinMerge;C:\Program Files (x86)\dotnet\;C:\Program Files\Microsoft SQL Server\150\Tools\Binn\;C:\Program Files\Graphviz\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\doxygen\bin;c:\Program Files\oracle\ocl;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;C:\Program Files\Git\cmd;C:\Program Files\PowerToys\DSCModules\;C:\WINDOWS\system32\config\systemprofile\AppData\Local\Microsoft\WindowsApps;C:\AVMProgramme\sonar\;C:\Users\whenze\AppData\Local\Programs\Python\Python39\Scripts\;C:\Users\whenze\AppData\Local\Programs\Python\Python39\;C:\Users\whenze\AppData\Local\Microsoft\WindowsApps;C:\Program Files (x86)\Qualcomm Atheros\Powerline Toolkit;C:\Program Files (x86)\Broadcom\l2command;C:\Users\whenze\source\powerline_tools\x64\Debug;C:\Users\whenze\AppData\Local\gitkraken\bin;%USERPROFILE%\AppData\Local\Microsoft\WindowsApps;
1>     SESSIONNAME=Console
1>     QTDIR=C:\Qt\6.8.3\msvc2022_64
1>     USERDNSDOMAIN=ADS.AVM.DE
1>     ProgramW6432=C:\Program Files
1>     PROCESSOR_IDENTIFIER=Intel64 Family 6 Model 158 Stepping 10, GenuineIntel
1>     ZES_ENABLE_SYSMAN=1
1>     TMP=C:\Users\whenze\AppData\Local\Temp
1>     PROCESSOR_ARCHITECTURE=AMD64
1>     WIX=C:\Program Files (x86)\WiX Toolset v3.14\
1>     PkgDefApplicationConfigFile=C:\Users\whenze\AppData\Local\Microsoft\VisualStudio\17.0_d41abe69\devenv.exe.config
1>     USERPROFILE=C:\Users\whenze
1>     VisualStudioDir=C:\Users\whenze\Documents\Visual Studio 2022
1>     PROCESSOR_REVISION=9e0a
1>     ServiceHubLogSessionKey=207F64F5
1>     FPS_BROWSER_APP_PROFILE_STRING=Internet Explorer
1>     FPS_BROWSER_USER_PROFILE_STRING=Default
1>     LOGONSERVER=\\AD-DC-02
1>     TEMP=C:\Users\whenze\AppData\Local\Temp
1>     ServiceHubHostServiceBrokerPipeName=\\.\pipe\F453602F-CD48-48D3-9234-A45142AD30BA
1>     SystemRoot=C:\WINDOWS
1>     VSSKUEDITION=Professional
1>     NLS_LANG=GERMAN_AMERICA.WE8ISO8859P1
1>     USERNAME=whenze
1>     QtMsBuild=C:\Users\whenze\AppData\Local\QtMsBuild
1>     ORACLE_HOME=c:\Program Files\oracle\ocl
1>     OneDrive=C:\Users\whenze\OneDrive
1>     BPPDOMAIN_MANAGER_TYPE=EdrDotNet.EdrAppDomainManager
1>     CommonProgramFiles(x86)=C:\Program Files (x86)\Common Files
1>     ProgramFiles(x86)=C:\Program Files (x86)
1>     ProgramData=C:\ProgramData
1>     VS_Perf_Session_GCHeapCount=2
1>     VSAPPIDDIR=C:\Program Files\Microsoft Visual Studio\2022\Professional\Common7\IDE\
1>     HOMEPATH=\Users\whenze
1>     COMPUTERNAME=W-WHENZE
1>     SignInWithHomeTenantOnly=False
1>     ALLUSERSPROFILE=C:\ProgramData
1>     CommonProgramW6432=C:\Program Files\Common Files
1>     MOZ_ALLOW_DOWNGRADE=1
1>     ThreadedWaitDialogDpiContext=-4
1>     EFC_13908_1592913036=1
1>     GCExpConfigUsedInSession=3
1>     CommonProgramFiles=C:\Program Files\Common Files
1>     BPPDOMAIN_MANAGER_ASM=EdrDotNet, Version+168.0.0.0, Culture+neutral, PublicKeyToken+da1b3922653ea916
1>     DriverData=C:\Windows\System32\Drivers\DriverData
1>     HOMEDRIVE=C:
1>     windir=C:\WINDOWS
1>     SystemDrive=C:
1>     NUMBER_OF_PROCESSORS=6
1>     OS=Windows_NT
1>     NWUSERNAME=whenze
1>     ProgramFiles=C:\Program Files
1>     ComSpec=C:\WINDOWS\system32\cmd.exe
1>     GIT_LFS_PATH=C:\Program Files\Git LFS
1>     PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC;.PY;.PYW
1>     VSLANG=1033
1>     JAVA_HOME=C:\Program Files\Eclipse Adoptium\jre-8.0.472.8-hotspot\
1>     PSModulePath=C:\Program Files\WindowsPowerShell\Modules;C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules;C:\Program Files\Intel\Wired Networking\
1>     USERNAMELONG=Werner Henze
1>     APPDATA=C:\Users\whenze\AppData\Roaming
1>     USERDOMAIN=ADS
1>     PROCESSOR_LEVEL=6
1>     LOCALAPPDATA=C:\Users\whenze\AppData\Local
1>     VisualStudioVersion=17.0
1>     VisualStudioEdition=Microsoft Visual Studio Professional 2022
1>     USERDOMAIN_ROAMINGPROFILE=ADS
1>     VsPerMonitorDpiAwarenessEnabled.14412=TRUE
1>     TNS_ADMIN=c:\Program Files\oracle\ocl
1>     PUBLIC=C:\Users\Public
1>     VSAPPIDNAME=devenv.exe
1>     MSBuildLoadMicrosoftTargetsReadOnly=true
1> Command line: "C:\WINDOWS\system32\cmd.exe" /c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "c:\program files\microsoft visual studio\2022\professional\common7\ide\commonextensions\microsoft\cmake\CMake\bin\cmake.exe"  -G "Unix Makefiles"  -DGSL_CXX_STANDARD:STRING="14" -DGSL_TEST:STRING="ON" -DCMAKE_CXX_COMPILER:STRING="clang++" -DCMAKE_C_COMPILER:STRING="clang" -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:/Users/whenze/source/GSL/install/clang-14-debug"   "C:\Users\whenze\source\GSL" 2>&1"
1> Working directory: C:/Users/whenze/source/GSL/build/clang-14-debug
1> [CMake] CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
1> [CMake] -- Configuring incomplete, errors occurred!
1> 'C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "c:\program files\microsoft visual studio\2022\professional\common7\ide\commonextensions\microsoft\cmake\CMake\bin\cmake.exe"  -G "Unix Makefiles"  -DGSL_CXX_STANDARD:STRING="14" -DGSL_TEST:STRING="ON" -DCMAKE_CXX_COMPILER:STRING="clang++" -DCMAKE_C_COMPILER:STRING="clang" -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:/Users/whenze/source/GSL/install/clang-14-debug"   "C:\Users\whenze\source\GSL" 2>&1"' execution failed with error: ''C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "c:\program files\microsoft visual studio\2022\professional\common7\ide\commonextensions\microsoft\cmake\CMake\bin\cmake.exe"  -G "Unix Makefiles"  -DGSL_CXX_STANDARD:STRING="14" -DGSL_TEST:STRING="ON" -DCMAKE_CXX_COMPILER:STRING="clang++" -DCMAKE_C_COMPILER:STRING="clang" -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:/Users/whenze/source/GSL/install/clang-14-debug"   "C:\Users\whenze\source\GSL" 2>&1"' returned with exit code: 1'.

To Reproduce
Open GSL project folder in VS 2022 (or VS 2026), build starts automatically.

Expected behavior
Build should succeeed like this:

1> CMake generation started for configuration: 'x64-Debug'.
1> Command line: "C:\WINDOWS\system32\cmd.exe" /c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "c:\program files\microsoft visual studio\2022\professional\common7\ide\commonextensions\microsoft\cmake\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\whenze\CMakeBuilds\f546632b-5fa0-4b3b-b5b4-6d8a694a47c4\install\x64-Debug" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Professional/VC/Tools/MSVC/14.44.35207/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Professional/VC/Tools/MSVC/14.44.35207/bin/Hostx64/x64/cl.exe"  -DGSL_CXX_STANDARD=17 -DCMAKE_MAKE_PROGRAM="c:\program files\microsoft visual studio\2022\professional\common7\ide\commonextensions\microsoft\cmake\Ninja\ninja.exe" "C:\Users\whenze\source\GSL" 2>&1"
1> Working directory: C:\Users\whenze\CMakeBuilds\f546632b-5fa0-4b3b-b5b4-6d8a694a47c4\build\x64-Debug
1> [CMake] -- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 
1> [CMake] -- Checking for one of the modules 'gtest_main'
1> [CMake] -- Configuring done (0.3s)
1> [CMake] -- Generating done (0.1s)
1> [CMake] -- Build files have been written to: C:/Users/whenze/CMakeBuilds/f546632b-5fa0-4b3b-b5b4-6d8a694a47c4/build/x64-Debug/tests/googletest-download
1> [CMake] [1/7] Performing update step for 'googletest'
1> [CMake] -- Already at requested tag: v1.14.0
1> [CMake] [2/7] No patch step for 'googletest'
1> [CMake] [3/7] No configure step for 'googletest'
1> [CMake] [4/7] No build step for 'googletest'
1> [CMake] [5/7] No install step for 'googletest'
1> [CMake] [6/7] No test step for 'googletest'
1> [CMake] [7/7] Completed 'googletest'
1> [CMake] -- Configuring done (4.2s)
1> [CMake] -- Generating done (0.2s)
1> [CMake] -- Build files have been written to: C:/Users/whenze/CMakeBuilds/f546632b-5fa0-4b3b-b5b4-6d8a694a47c4/build/x64-Debug
1> Extracted CMake variables.
1> Extracted source files and headers.
1> Extracted code model.
1> Extracted toolchain configurations.
1> Extracted includes paths.
1> CMake generation finished.

Spec (please complete the following information):

• Windows
• MSVC (VS 2022, VS 2026)

Additional context
The bug was introduced in c31617f ("use cmake presets instead of cmake settings (#1219)")

[carsonRadtke]

Thanks for reporting this issue!

In #1219, the default generator was changed from Ninja to Unix Makefiles (for clang and gcc). This is obviously breaking your workflow, so we should revert the default generator back to Ninja for all compilers.

Quick Question: did you select clang-14-debug? Or was that the default mode? I wonder if on Windows, we should default to something like msvc-20-debug.

[beinhaerter]

Quick Question: did you select clang-14-debug? Or was that the default mode? I wonder if on Windows, we should default to something like msvc-20-debug.

I did not select anything. I just open the project folder, then without any further action or selection of me MSVC detects the cmake configuration and starts building the tests. If there is a new way and I should select something first, please advise me what to do and I can check that.