example code for TKInter hello world program missing reference

[timeulen]

Documentation

link to page: https://github.com/python/cpython/blob/main/Doc/library/tkinter.rst
the following code needs to be updated as highlighted:

from tkinter import *
from tkinter import ttk
root **= tkinter.** Tk()
frm = ttk.Frame(root, padding=10)
frm.grid()
ttk.Label(frm, text="Hello World!").grid(column=0, row=0)
ttk.Button(frm, text="Quit", command=root.destroy).grid(column=1, row=0)
root.mainloop()

[terryjreedy]

The 'tkinter.rst' link actually goes to a useless search page, https://github.com/python/cpython/issues/created_by/url. So there is no actual report yet.

[hugovk]

I fixed the Markdown, the link is https://github.com/python/cpython/blob/main/Doc/library/tkinter.rst

More specifically: https://docs.python.org/3/library/tkinter.html#a-hello-world-program

And they suggest this change:

    from tkinter import *
    from tkinter import ttk
-   root = Tk()
+   root = tkinter.Tk()
    frm = ttk.Frame(root, padding=10)
    frm.grid()
    ttk.Label(frm, text="Hello World!").grid(column=0, row=0)
    ttk.Button(frm, text="Quit", command=root.destroy).grid(column=1, row=0)
    root.mainloop()

So change:

from tkinter import *
from tkinter import ttk
root = Tk()
frm = ttk.Frame(root, padding=10)
frm.grid()
ttk.Label(frm, text="Hello World!").grid(column=0, row=0)
ttk.Button(frm, text="Quit", command=root.destroy).grid(column=1, row=0)
root.mainloop()

Into:

from tkinter import *
from tkinter import ttk
root = tkinter.Tk()
frm = ttk.Frame(root, padding=10)
frm.grid()
ttk.Label(frm, text="Hello World!").grid(column=0, row=0)
ttk.Button(frm, text="Quit", command=root.destroy).grid(column=1, row=0)
root.mainloop()

However, on macOS, the original opens the example as expected:

But the proposed change gives:

>>> from tkinter import *
... from tkinter import ttk
... root = tkinter.Tk()
... frm = ttk.Frame(root, padding=10)
... frm.grid()
... ttk.Label(frm, text="Hello World!").grid(column=0, row=0)
... ttk.Button(frm, text="Quit", command=root.destroy).grid(column=1, row=0)
... root.mainloop()
...
Traceback (most recent call last):
  File "<python-input-0>", line 3, in <module>
    root = tkinter.Tk()
           ^^^^^^^
NameError: name 'tkinter' is not defined. Did you forget to import 'tkinter'?

[picnixz]

I would suggest changing from tkinter import * into from tkinter import Tk if there is a real concern.

[serhiy-storchaka]

I do not think there is a problem here.

While the star import is discouraged in general, it is okay for small examples, scripts and REPL, and it is more than okey when you play with Tkinter, because it exports tons of names. Repeating the tkinter. prefix would be boring and painful.

[picnixz]

Ok, so let's leave it as is (which I think it's fine).