Invalid function call in generated output

[alex35mil]

// External binding to global "test"
@val external _test: (string, (unit => unit) => unit) => unit = "test"

// Wrapper function shadows the external's target name
let test = (name, callback) => {
  _test(name, _done => callback())
}

// BUG: This should call global test(), but calls local wrapper instead
let broken = () => {
  _test("async", done => done())
}

Generates:

// Generated by ReScript, PLEASE EDIT WITH CARE


function test(name, callback) {
  globalThis.test(name, _done => callback());
}

function broken() {
  test("async", done => done());
}

export {
  test,
  broken,
}
/* No side effect */

[dsiu]

Adding@scope("globalThis") to external binding seems to fix this issue. I ain't sure if this is the righ behavior since it was introduced in v12.0.2.

rescript-jest is failing because of this issue and I had to submitted a similar pull request // @glensc

// External binding to global "test"
@val @scope("globalThis")
external _test: (string, (unit => unit) => unit) => unit = "test"

// Wrapper function shadows the external's target name
let test = (name, callback) => {
  _test(name, _done => callback())
}

// BUG: This should call global test(), but calls local wrapper instead
let broken = () => {
  _test("async", done => done())
}

// Generated by ReScript, PLEASE EDIT WITH CARE


function test(name, callback) {
  globalThis.test(name, _done => callback());
}

function broken() {
  globalThis.test("async", done => done());
}

export {
  test,
  broken,
}
/* No side effect */