From 81d446bc7acb8e02d8cbda5bcc99636354a2ba3c Mon Sep 17 00:00:00 2001 From: CCleanerShot <31040856+CCleanerShot@users.noreply.github.com> Date: Mon, 6 Oct 2025 12:02:41 -0800 Subject: [PATCH 1/2] fixed typo of 'reponse' --- lib/serpapi/client.rb | 4 ++-- spec/serpapi/client/client_spec.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/serpapi/client.rb b/lib/serpapi/client.rb index ff1e583..7dba7c9 100644 --- a/lib/serpapi/client.rb +++ b/lib/serpapi/client.rb @@ -231,7 +231,7 @@ def get(endpoint, decoder = :json, params = {}) if data.instance_of?(Hash) && data.key?(:error) raise SerpApiError, "HTTP request failed with error: #{data[:error]} from url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}, response status: #{response.status} " elsif response.status != 200 - raise SerpApiError, "HTTP request failed with response status: #{response.status} reponse: #{data} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}" + raise SerpApiError, "HTTP request failed with response status: #{response.status} response: #{data} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}" end rescue JSON::ParserError raise SerpApiError, "JSON parse error: #{response.body} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}, response status: #{response.status}" @@ -244,7 +244,7 @@ def get(endpoint, decoder = :json, params = {}) when :html # html decoder if response.status != 200 - raise SerpApiError, "HTTP request failed with response status: #{response.status} reponse: #{data} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}" + raise SerpApiError, "HTTP request failed with response status: #{response.status} response: #{data} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}" end response.body diff --git a/spec/serpapi/client/client_spec.rb b/spec/serpapi/client/client_spec.rb index a5f395c..ab33d35 100644 --- a/spec/serpapi/client/client_spec.rb +++ b/spec/serpapi/client/client_spec.rb @@ -90,7 +90,7 @@ begin client.send(:get, '/invalid', :html, {}) rescue SerpApi::SerpApiError => e - expect(e.message).to include(/HTTP request failed with response status: 404 Not Found reponse/), "got #{e.message}" + expect(e.message).to include(/HTTP request failed with response status: 404 Not Found response/), "got #{e.message}" rescue => e raise("wrong exception: #{e}") end From 7edfb551c5cd0b57ed4f64a3fde98b391aabfa31 Mon Sep 17 00:00:00 2001 From: CCleanerShot <31040856+CCleanerShot@users.noreply.github.com> Date: Mon, 6 Oct 2025 12:08:02 -0800 Subject: [PATCH 2/2] added commas to separate various error fields --- lib/serpapi/client.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/serpapi/client.rb b/lib/serpapi/client.rb index 7dba7c9..0361d20 100644 --- a/lib/serpapi/client.rb +++ b/lib/serpapi/client.rb @@ -229,12 +229,12 @@ def get(endpoint, decoder = :json, params = {}) # parse JSON response with Ruby standard library data = JSON.parse(response.body, symbolize_names: symbolize_names) if data.instance_of?(Hash) && data.key?(:error) - raise SerpApiError, "HTTP request failed with error: #{data[:error]} from url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}, response status: #{response.status} " + raise SerpApiError, "HTTP request failed with error: #{data[:error]}, from url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}, response status: #{response.status} " elsif response.status != 200 - raise SerpApiError, "HTTP request failed with response status: #{response.status} response: #{data} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}" + raise SerpApiError, "HTTP request failed with response status: #{response.status}, response: #{data} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}" end rescue JSON::ParserError - raise SerpApiError, "JSON parse error: #{response.body} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}, response status: #{response.status}" + raise SerpApiError, "JSON parse error: #{response.body}, on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}, response status: #{response.status}" end # discard response body @@ -244,7 +244,7 @@ def get(endpoint, decoder = :json, params = {}) when :html # html decoder if response.status != 200 - raise SerpApiError, "HTTP request failed with response status: #{response.status} response: #{data} on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}" + raise SerpApiError, "HTTP request failed with response status: #{response.status}, response: #{data}, on get url: https://#{BACKEND}#{endpoint}, params: #{params}, decoder: #{decoder}" end response.body