chore: accept time argument in not_start mock of timer start#1350
Merged
chore: accept time argument in not_start mock of timer start#1350
time argument in not_start mock of timer start#1350Conversation
To improve readability of stactrace accept the time argument.
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates a QTimer.start mock helper in tests so the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
📝 WalkthroughWalkthroughThe test configuration file is updated to modify a patching stub method. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- To make the mock more robust against future changes in
QTimer.start, consider matching its full signature (e.g., using*args, **kwargsor the exact parameter name and type) rather than only adding an optionaltime=Noneargument.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- To make the mock more robust against future changes in `QTimer.start`, consider matching its full signature (e.g., using `*args, **kwargs` or the exact parameter name and type) rather than only adding an optional `time=None` argument.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1350 +/- ##
===========================================
- Coverage 93.17% 93.15% -0.02%
===========================================
Files 210 210
Lines 33251 33251
===========================================
- Hits 30981 30976 -5
- Misses 2270 2275 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package/tests/test_PartSeg/conftest.py`:
- Around line 93-94: The stub method not_start currently raises a RuntimeError
but its signature (self, time=None) triggers Ruff ARG001 for unused args; update
the not_start definition to either accept arbitrary args (def not_start(self,
*args, **kwargs):) or annotate the existing parameters with a noqa (e.g. def
not_start(self, time=None): # noqa: ARG001) and keep the RuntimeError,
referencing the not_start method to locate the change.
Comment on lines
+93
to
94
| def not_start(self, time=None): | ||
| raise RuntimeError("Thread should not be used in test") |
Contributor
There was a problem hiding this comment.
Silence Ruff ARG001 for the unused stub parameters.
Ruff flags unused self and time here. Either ignore via # noqa: ARG001 or accept arbitrary args to keep lint clean.
💡 Minimal fix
- def not_start(self, time=None):
+ def not_start(*_, **__):
raise RuntimeError("Thread should not be used in test")🧰 Tools
🪛 Ruff (0.14.14)
[warning] 93-93: Unused function argument: self
(ARG001)
[warning] 93-93: Unused function argument: time
(ARG001)
[warning] 94-94: Avoid specifying long messages outside the exception class
(TRY003)
🤖 Prompt for AI Agents
In `@package/tests/test_PartSeg/conftest.py` around lines 93 - 94, The stub method
not_start currently raises a RuntimeError but its signature (self, time=None)
triggers Ruff ARG001 for unused args; update the not_start definition to either
accept arbitrary args (def not_start(self, *args, **kwargs):) or annotate the
existing parameters with a noqa (e.g. def not_start(self, time=None): # noqa:
ARG001) and keep the RuntimeError, referencing the not_start method to locate
the change.
Czaki
changed the title
time arguemt in not_start mock of timer starttime argumet in not_start mock of timer start
Czaki
changed the title
time argumet in not_start mock of timer starttime argument in not_start mock of timer start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve readability of the stack trace, accept the
timeargument.Summary by Sourcery
Tests:
Summary by CodeRabbit