add more guards for check if in a proper thread by Czaki · Pull Request #757 · 4DNucleome/PartSeg

Czaki · 2022-10-16T18:58:25Z

No description provided.

sourcery-ai · 2022-10-16T18:58:37Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 0.06%.

Quality metrics	Before	After	Change
Complexity	4.86 ⭐	4.92 ⭐	0.06 👎
Method Length	82.56 🙂	82.14 🙂	-0.42 👍
Working memory	7.80 🙂	7.80 🙂	0.00
Quality	65.26% 🙂	65.20% 🙂	-0.06% 👎

Other metrics	Before	After	Change
Lines	1109	1125	16

Changed files	Quality Before	Quality After	Quality Change
package/PartSeg/common_gui/napari_image_view.py	64.73% 🙂	64.45% 🙂	-0.28% 👎
package/PartSeg/common_gui/napari_viewer_wrap.py	67.45% 🙂	68.18% 🙂	0.73% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
package/PartSeg/common_gui/napari_image_view.py	ImageView.print_info	19 😞	178 😞	11 😞	41.13% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py	ImageView._add_image	16 🙂	343 ⛔	8 🙂	41.43% 😞	Try splitting into smaller methods
package/PartSeg/common_gui/napari_image_view.py	ImageView.component_mark	14 🙂	262 ⛔	10 😞	41.47% 😞	Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py	ImageView.__init__	1 ⭐	730 ⛔	14 😞	42.17% 😞	Try splitting into smaller methods. Extract out complex expressions
package/PartSeg/common_gui/napari_image_view.py	ImageView._mark_layer	8 ⭐	259 ⛔		45.88% 😞	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

deprecated-napari-hub-preview-bot · 2022-10-16T19:08:46Z

Preview page for your plugin is ready here:
https://preview.napari-hub.org/4DNucleome/PartSeg/757
Created: 2022-10-16T19:08:32.976887

codecov · 2022-10-16T19:19:44Z

Codecov Report

Base: 88.91% // Head: 88.91% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0bcb053) compared to base (7f59296).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #757      +/-   ##
===========================================
- Coverage    88.91%   88.91%   -0.01%     
===========================================
  Files          190      190              
  Lines        29559    29569      +10     
===========================================
+ Hits         26282    26290       +8     
- Misses        3277     3279       +2

Impacted Files	Coverage Δ
package/PartSeg/common_gui/napari_viewer_wrap.py	`97.80% <71.42%> (-1.06%)`	⬇️
package/PartSeg/common_gui/napari_image_view.py	`84.85% <80.00%> (+0.05%)`	⬆️