feat: Workaround for libraries that put the macOS keyboard focus on the window rather than the content view#266
Merged
mwcampbell merged 4 commits intomainfrom Aug 7, 2023
Conversation
…he window rather than the content view
madsmtm
reviewed
Aug 7, 2023
DataTriny
requested changes
Aug 7, 2023
Member
DataTriny
left a comment
DataTriny
left a comment
There was a problem hiding this comment.
Probably better to let macOS experts have a close look at this one!
DataTriny
approved these changes
Aug 7, 2023
Merged
Contributor
Author
|
Mads said it was fine, so I've gone ahead and merged it. |
lunixbochs
pushed a commit
to talonvoice/accesskit
that referenced
this pull request
Aug 31, 2023
…he window rather than the content view (AccessKit#266)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the macOS focus problem discussed in #250.
@madsmtm I had to copy some code from objc2 in order to add a method to an existing class. That was the only solution I could find; creating a subclass and changing the class of the window instance led to very broken behavior (the window never appeared), likely because
NSWindowuses KVO.