Treat empty environment variables like unset ones#131
Open
clbarnes wants to merge 2 commits intoActiveState:masterfrom
Open
Treat empty environment variables like unset ones#131clbarnes wants to merge 2 commits intoActiveState:masterfrom
clbarnes wants to merge 2 commits intoActiveState:masterfrom
Conversation
As per the XDG spec. Previously, empty variables would be used as-is.
McSinyx
suggested changes
Feb 20, 2020
McSinyx
left a comment
McSinyx
left a comment
There was a problem hiding this comment.
I'm favoring this change (although I'm not somebody in charge if that's not obvious) but a few tiny details.
* Shorten getenv function * Fix formatting
xavfernandez
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #130
As per the XDG spec. Previously, empty variables would be used as-is.
Breaking change, but necessary for spec compliance.