Open
Conversation
CheezItMan
reviewed
Apr 6, 2022
Contributor
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
One note, please make PRs against the Ada-C16 remote repo.
Nice work Zandra, you hit the required methods. Well done. I left a few minor comments, but this is a nice submission.
Comment on lines
+18
to
21
| # Time Complexity: (O)1? | ||
| # Space Complexity: O(1)? | ||
|
|
||
| def get_first(self): |
Comment on lines
+29
to
32
| # Time Complexity: (O)1? | ||
| # Space Complexity: O(1)? | ||
|
|
||
| def add_first(self, value): |
Comment on lines
+40
to
43
| # Time Complexity: O(n)? | ||
| # Space Complexity: O(1)? | ||
|
|
||
| def search(self, value): |
Comment on lines
+58
to
61
| # Time Complexity: O(n)? | ||
| # Space Complexity: O(1)? | ||
|
|
||
| def length(self): |
Comment on lines
+75
to
78
| # Time Complexity: O(n)? | ||
| # Space Complexity: O(1)? | ||
|
|
||
| def get_at_index(self, index): |
Comment on lines
+113
to
116
| # Time Complexity: O(n)? | ||
| # Space Complexity: O(n)? | ||
|
|
||
| def add_last(self, value): |
Contributor
There was a problem hiding this comment.
👍 However the space complexity here is O(1)
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
|
|
||
| def find_max(self): |
Comment on lines
+152
to
154
| # Time Complexity: O(n)? | ||
| # Space Complexity: O(1)? | ||
| def delete(self, value): |
Comment on lines
+173
to
176
| # Time Complexity: O(n)? | ||
| # Space Complexity: O(n)? | ||
|
|
||
| def visit(self): |
Comment on lines
+188
to
191
| # Time Complexity: O(n) ? | ||
| # Space Complexity: O(1)? | ||
|
|
||
| def reverse(self): |
Contributor
There was a problem hiding this comment.
👍 However think about better variable names than p1 and p2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.