Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dosubot
bot
added
the
size:L
There was a problem hiding this comment.
Pull Request Overview
This PR adds a GitHub Actions workflow to automate version bumping across multiple project components (web, ee, oss, sdk, api) and create a release branch with a pull request.
- Automates version bumping using semver for patch, minor, or major releases
- Creates a release branch and PR when versions match across all components
- Includes a tag creation job after successful version bump
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Bump versions and compare | ||
| id: bump_versions | ||
| run: | | ||
| BUMP_TYPE=${{ inputs.bump-type }} |
There was a problem hiding this comment.
The input parameter is defined as 'release-type' (line 6) but referenced as 'bump-type' here. This should be 'inputs.release-type' to match the workflow input definition.
| BUMP_TYPE=${{ inputs.bump-type }} | |
| BUMP_TYPE=${{ inputs.release-type }} |
|
|
||
| - name: Create Pull Request | ||
| if: steps.bump_versions.outputs.VERSIONS_MATCH == 'true' | ||
| uses: peter-evans/create-pull-request@v6 |
There was a problem hiding this comment.
The step is missing an 'id' field. The job output on line 23 references 'steps.create-pr.outputs.pull-request-number', but this step doesn't have 'id: create-pr' defined, which will cause the output reference to fail.
| - name: Create and push tag | ||
| run: | | ||
| git config --global user.name "${{ github.actor }}" | ||
| git config --global user.email "${{ github.actor_id }}+${{ github.actor }}@users.noreply.github.com" | ||
| git tag -a "v${{ needs.bump-version.outputs.new_version }}" -m "Version ${{ needs.bump-version.outputs.new_version }}" | ||
| git push origin "v${{ needs.bump-version.outputs.new_version }}" |
There was a problem hiding this comment.
The create-tag job checks out the repository but doesn't specify which branch or ref to checkout. Since this job runs after the PR is created, it will checkout the default branch (likely main), not the release branch where the version bump was committed. The tag will be created on the wrong commit. Consider adding 'ref: release/v${{ needs.bump-version.outputs.new_version }}' to the checkout step or removing the tag creation until after the PR is merged.
2 participants
No description provided.