Update renderer, pathfinding, collision handling, and book display for Alex’s Caves and Alex’s Mobs 1.21 #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or improved functionality
…x shader; add new sobel vertex shader
…olor and adjust entity rotation handling
… improved AI navigation
…ement logic; add EntityMixin for collision adjustments
…ision method for custom collision handling
There was a problem hiding this comment.
Pull request overview
This PR updates the Citadel library to support Minecraft 1.21 for Alex's Caves and Alex's Mobs mods. The changes primarily focus on shader rendering updates, pathfinding improvements, collision handling enhancements, and GUI rendering fixes.
Changes:
- Updated shader files to fix texture coordinate calculations and implement proper blur/bumpy effects for 1.21
- Implemented synchronous pathfinding methods to support vanilla AI goals
- Enhanced collision handling with better null safety and custom collision support
- Fixed GUI book rendering to prevent dark overlay issues in 1.21
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sobel.vsh | Added OutSize uniform and updated texture coordinate calculation |
| bumpy.vsh, bumpy.fsh, bumpy.json | Rewrote bumpy shader with proper edge detection algorithm |
| blur.fsh, blur.json | Updated blur shader implementation and vertex shader reference |
| blit.vsh, blit.json, blit.fsh | Removed unused blit shader files |
| accesstransformer.cfg | Made Entity.collide() public for custom collision support |
| AdvancedPathNavigate.java | Implemented synchronous pathfinding for vanilla AI goal compatibility |
| MovementControllerCustomCollisions.java | Added null safety checks for pathfinding navigation |
| CustomCollisionsNodeProcessor.java | Optimized BlockPos creation and added NotNull annotations |
| CustomCollisionsNavigator.java | Refactored canMoveDirectly to eliminate redundant static method |
| PostEffectRegistry.java | Added debug logging for shader initialization |
| GuiBasicBook.java | Fixed entity rendering for 1.21 and prevented dark menu background |
| BookBlit.java | Added shader color reset to fix rendering artifacts |
| Citadel.java | Registered SyncClientTickRateMessage for client-server synchronization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/github/alexthe666/citadel/client/gui/GuiBasicBook.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.