Skip to content

Conversation

@FDUEnrich
Copy link
Contributor

No description provided.

FDUEnrich and others added 24 commits October 12, 2025 15:07
[PWGHF] Please consider the following formatting changes to AliceO2Group#13353
Added new mass columns for Omega and Xi particles and updated event selection criteria.
@vkucera vkucera marked this pull request as draft December 18, 2025 14:20
@vkucera
Copy link
Collaborator

vkucera commented Dec 18, 2025

Stop wasting compilation resources! Your PR doesn't pass required tests and you haven't addressed my comments, so why did you open the PR for review?

@FDUEnrich FDUEnrich marked this pull request as ready for review December 24, 2025 10:23
@vkucera vkucera marked this pull request as draft December 24, 2025 16:19
@FDUEnrich FDUEnrich marked this pull request as ready for review December 26, 2025 06:32
@vkucera vkucera marked this pull request as draft December 26, 2025 13:11
@FDUEnrich FDUEnrich marked this pull request as ready for review December 29, 2025 13:29
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 9d4f31c at 2025-12-30 15:40:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

Comment on lines 355 to 356
{"hMassXiPi", "inv. mass #Xi + #pi;inv. mass (GeV/#it{c}^{2})", {HistType::kTH1D, {{400, 1.5, 3.}}}},
{"hMassXiPiVsPt", "inv. mass #Xi + #pi;inv. mass (GeV/#it{c}^{2});p_{T} (GeV/#it{c})", {HistType::kTH2D, {{400, 1.5, 3.}, {10, 0., 10.}}}},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hMassXiPi is redundant

Comment on lines 808 to 810
default:
passSelectedChannel = true; // unexpected code -> do not reject
break;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you silently accept unexpected cases?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of doing this?

@vkucera vkucera marked this pull request as draft January 8, 2026 00:36
Updated variable names for clarity and consistency in the treeCreatorOmegacSt.cxx file. Removed unused histogram for mass Xi + pi.
@FDUEnrich FDUEnrich marked this pull request as ready for review January 8, 2026 13:43
@vkucera vkucera marked this pull request as draft January 12, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants