Conversation
Collaborator
Author
|
We have to go through the transaction support PRs first since they touch the same code, and then we can move on to this. |
hoan301298
approved these changes
Feb 9, 2026
Member
hoan301298
left a comment
There was a problem hiding this comment.
Looks good to me. But if you can change a bit more, that could be nice.
Member
There was a problem hiding this comment.
I suggest to add
setSenderId(id: string) {
this.base.sender_id = id;
return this;
}| let chatService: ChatService; | ||
| const chatMessageBuilder = ChatBuilderFactory.getBuilder('ChatMessage'); | ||
| const chatModel = ChatModule.getChatModel(); | ||
| const mockSenderId = '60f7c2d9a2d3c7b7e56d01df'; |
Member
There was a problem hiding this comment.
This comment is up to you if you want it simple like using the senderId below to pass into addReaction(). This action means the sender also reacting with his message. Or another sender react to it like you did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
This PR implements the requirement to include the player's unique ID
(sender_id)within chat reactions. This ensures the frontend can reliably identify the author of a reaction, consistent with ourChatMessageownership model.Change list
Reactionclass inreaction.schema.tsto includesender_idas a required String property.ReactionDtoandCreateReactionDtoto enforce the inclusion ofsender_id.ChatService.addReaction()to acceptsender_idas a mandatory 4th argument.BaseChatServiceand gateways to extract theplayerIdfrom the authenticated socket client and pass it through to the service layer.ReactionDtoBuilderandChatBuilderFactorywith default mock IDs to satisfy TypeScript's strict requirements across all existing tests.addReaction.test.tsto verify thatsender_idis correctly persisted and returned.