Open
Conversation
Owner
|
Thanks for the PR! I think the root cause of #153 is something else. IIRC gocomics messed with URLs and I wasn't handling them right? Maybe still am not? I don't recall why I forced it to keep at least one comic strip, so I don't know whether or not I want to bump that number up. |
Author
|
Sure thing, wasn't sure if that was the desired behavior anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for #153
Since these are all old strips that aren't being updated, they are never more recent than
expirationDate, which means only the first strip is kept:To mitigate this I added a
minimumCountvariable that applies globally, but this could also be moved to a per-scraper value.Not sure what the other options are since these aren't being updated, but if there's still a desire to see some in the feed then this is probably the best compromise.
comicsrss.com/_generator/bin.js
Lines 128 to 134 in 8aecc97