Skip to content

fix: prevent duplicate features in bulk creation #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
exbald wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent duplicate features in bulk creation #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions mcp_server/feature_mcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,9 +546,25 @@ def feature_create_bulk(
"error": f"Feature at index {i} cannot depend on feature at index {idx} (forward reference not allowed)"
})

# Second pass: create all features
# Second pass: check for existing features to avoid duplicates
existing = set()
for f in session.query(Feature.category, Feature.name).all():
existing.add((f.category, f.name))

# Filter out duplicates from input batch
unique_features = []
skipped = 0
for feature_data in features:
key = (feature_data["category"], feature_data["name"])
if key in existing:
skipped += 1
else:
unique_features.append(feature_data)
existing.add(key) # Mark as will-exist for batch dedup

# Third pass: create unique features only
created_features: list[Feature] = []
for i, feature_data in enumerate(features):
for i, feature_data in enumerate(unique_features):
db_feature = Feature(
priority=start_priority + i,
category=feature_data["category"],
Expand All @@ -564,9 +580,9 @@ def feature_create_bulk(
# Flush to get IDs assigned
session.flush()

# Third pass: resolve index-based dependencies to actual IDs
# Fourth pass: resolve index-based dependencies to actual IDs
deps_count = 0
for i, feature_data in enumerate(features):
for i, feature_data in enumerate(unique_features):
indices = feature_data.get("depends_on_indices", [])
if indices:
# Convert indices to actual feature IDs
Expand All @@ -578,6 +594,7 @@ def feature_create_bulk(

return json.dumps({
"created": len(created_features),
"skipped_duplicates": skipped,
"with_dependencies": deps_count
})
except Exception as e:
Expand Down