feat: Add ideation context settings #667
Conversation
- Add settings popover to the ideation view - Migrate previous context to toggles (memory, context, features, ideas) - Add app specifications as new context option
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdds per-project toggles for ideation context sources and threads an optional Changes
Sequence DiagramsequenceDiagram
participant User as User (UI)
participant Popover as IdeationSettingsPopover
participant Store as Zustand Store
participant Mutation as useIdeationMutations
participant HTTPClient as HttpApiClient
participant Server as IdeationService (Server)
participant FS as FileSystem
participant Provider as LLM Provider
User->>Popover: Toggle context source
Popover->>Store: setContextSource(projectPath, key, value)
Store->>Store: persist contextSourcesByProject
User->>Mutation: Click "Generate Ideas"
Mutation->>Store: getContextSources(projectPath)
Store-->>Mutation: merged IdeationContextSources
Mutation->>HTTPClient: generateSuggestions(..., contextSources)
HTTPClient->>Server: POST /api/ideation/suggestions/generate {..., contextSources}
Server->>Server: merge with DEFAULT_IDEATION_CONTEXT_SOURCES
alt useAppSpec enabled
Server->>FS: getAppSpecPath & read app_spec.txt
FS-->>Server: app_spec content
Server->>Server: buildAppSpecContext()
end
alt useContextFiles enabled
Server->>FS: loadContextFiles()
FS-->>Server: context files
end
alt useExistingFeatures/useExistingIdeas enabled
Server->>Server: gatherExistingWorkContext(options)
end
Server->>Server: assemble systemPrompt & call Provider
Server->>Provider: provider.chat(...)
Provider-->>Server: response
Server-->>HTTPClient: suggestions[]
HTTPClient-->>Mutation: {success, suggestions}
Mutation-->>User: render suggestions
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @Monoquark, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the ideation feature by providing users with granular control over the context used for generating suggestions. By introducing a dedicated settings popover and integrating 'App Specification' as a new context source, the system can now produce more relevant and focused ideas based on user preferences, improving the overall quality and utility of the ideation process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new settings popover for ideation, allowing users to configure which context sources are used for generating ideas. The changes are well-implemented across the frontend, state management, and backend services. A new context source from app_spec.txt has also been added. The code is of high quality, with good test coverage for the new backend logic. I've pointed out a minor area for improvement regarding redundant code in the ideation-service to enhance maintainability.
- Removed the suggestionCount variable that was re-clamping the count parameter - Removed default values from function parameters (count: number = 10 → count: number)
Shironex
added
Enhancement
2 participants
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.