-
Notifications
You must be signed in to change notification settings - Fork 509
fix: Custom pipeline columns UI not updating correctly #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Custom pipeline columns UI not updating correctly #677
Conversation
When a pipeline step starts, the feature status changes to the pipeline column status. Previously, only the single feature query was invalidated, but the Kanban board uses the all features query for column grouping. This caused the UI to not immediately reflect features moving to custom pipeline columns - updates would only appear after the first pipeline step completed. Fixes #668 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @Shironex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical UI synchronization bug affecting the Kanban board. Previously, when a feature transitioned into a custom pipeline column, the board's display would not update instantly due to an oversight in query invalidation. The changes ensure that the Kanban board now accurately and immediately reflects these status changes, providing a more responsive and reliable user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughThis change modifies the query invalidation logic in the UI hooks to ensure the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a UI bug on the Kanban board where features didn't update their column immediately. The fix correctly invalidates the features.all query on the pipeline_step_started event, ensuring the board refreshes. The related redundant invalidation for features.single is also cleanly removed. The changes are correct and well-commented. I've added a couple of suggestions to improve code readability and maintainability by refactoring the long if conditions.
Summary
Problem
When a pipeline step starts, the feature status changes to the pipeline column status. Previously, only the single feature query was invalidated, but the Kanban board uses the all features query for column grouping.
This caused the UI to not immediately reflect features moving to custom pipeline columns - updates would only appear after the first pipeline step completed.
Root Cause
In
use-query-invalidation.ts, thepipeline_step_startedevent was only invalidating the single feature query (queryKeys.features.single), but the Kanban board relies on the all features query (queryKeys.features.all) to determine column grouping.Solution
Added
pipeline_step_startedto the event handler that also invalidatesqueryKeys.features.all(), ensuring the Kanban board immediately reflects when a feature moves to a custom pipeline column.Test plan
Closes #668
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.