Conversation
088d25c to
0dbdce2
Compare
JoeLambourne
approved these changes
Jul 10, 2024
Contributor
JoeLambourne
left a comment
There was a problem hiding this comment.
This looks good.
I'm recommending updating the major version because we pull in a new PythonOCC which does force consumers to update OCC related code
Collaborator
Author
Collaborator
|
@JJMinton is this PR ready to merge? |
|
这是来自QQ邮箱的假期自动回复邮件。你好,我(yyx)已收到邮件,感谢您的来信!
|
|
Did this get merged? Would love to use 7.8.1 so that it doesn't break my other dependencies. |
|
这是来自QQ邮箱的假期自动回复邮件。你好,我(yyx)已收到邮件,感谢您的来信!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates pythonocc-core from v7.5.1 to v7.8.1.
This required
.Nodes().Value(idx)functions with.Node(idx).As a bonus, I have removed numerous unused imports.