Skip to content

Conversation

@YiyangZhao215
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 30, 2026 23:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new troubleshooting guide for SBE updates failing on 2601 due to the DeployADLess parameter issue and wires it into the Update TSG index. It documents the scenario, root cause, and provides a PowerShell mitigation script to add the missing CloudParameters entry.

Changes:

  • Introduced SBE-Update-Fails-with-Cannot-Validate-Argument-on-Parameter-DeployADLess.md describing the 2601 SBE update failure, its root cause, and a corrective script to add the DeployADLess parameter.
  • Updated TSG/Update/README.md to include the new TSG entry and fix the formatting of the preceding 2509 entry.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
TSG/Update/SBE-Update-Fails-with-Cannot-Validate-Argument-on-Parameter-DeployADLess.md New TSG describing the DeployADLess validation failure on 2601 and providing a PowerShell script to add the missing CloudParameters entry safely and idempotently.
TSG/Update/README.md Adds a link to the new SBE DeployADLess TSG and normalizes the formatting of the existing 2509 entry in the Update TSG list.


DeployADLess parameter entry was introduced in version 2408, but is only applicable to clusters deployed on this version or later. For earlier clusters, update process did not insert the entry to CloudParameters.

2601 introduced some new SBE scripts that depends on the value of this parameter. In the absence of the parameter, the value becomes the placeholder literal string '[DEPLOYADLESS]'. This value is unexpected by the script and thus fails the update.
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the sentence "2601 introduced some new SBE scripts that depends on the value of this parameter.", the subject is plural ("scripts"), so the verb should also be plural ("depend") for correct grammar and clearer reading.

Suggested change
2601 introduced some new SBE scripts that depends on the value of this parameter. In the absence of the parameter, the value becomes the placeholder literal string '[DEPLOYADLESS]'. This value is unexpected by the script and thus fails the update.
2601 introduced some new SBE scripts that depend on the value of this parameter. In the absence of the parameter, the value becomes the placeholder literal string '[DEPLOYADLESS]'. This value is unexpected by the script and thus fails the update.

Copilot uses AI. Check for mistakes.
"@
$null = $eceClient.UpdateCloudParameters($parametersUpdateDefinition).GetAwaiter().GetResult()
Write-Output "Validating add DeployADLess parameter"
$null = $ececlient.InvalidateCloudDefinitionCache().GetAwaiter().GetResult()
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable is declared as $eceClient earlier in the script but referenced here as $ececlient with different casing; while PowerShell variable names are case-insensitive, using consistent casing improves readability and avoids confusion when scanning for variable usages.

Suggested change
$null = $ececlient.InvalidateCloudDefinitionCache().GetAwaiter().GetResult()
$null = $eceClient.InvalidateCloudDefinitionCache().GetAwaiter().GetResult()

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant