Skip to content

Conversation

@fangfei
Copy link
Contributor

@fangfei fangfei commented Feb 1, 2026

Add new TSG for below validators:

  • Troubleshoot: Add Node Network ATC Service
  • Troubleshoot: AKS DNS Server CIDR Overlap
  • Troubleshoot: AKS POD CIDR IP Pool Overlap
  • Troubleshoot: AKS Proxy Server CIDR Overlap
  • Troubleshoot: AKS Service CIDR IP Pool Overlap
  • Troubleshoot: Cluster Network Intent Status
  • Troubleshoot: Cluster Management Intent Exists
  • Troubleshoot: Cluster Storage Intent Exists
  • Troubleshoot: Infrastructure IP Azure Endpoint Connection
  • Troubleshoot: Infrastructure IP DNS Client Readiness
  • Troubleshoot: Infrastructure IP DNS Port 53 Connection
  • Troubleshoot: Infrastructure IP Hyper-V Readiness
  • Troubleshoot: Infrastructure IP IP Readiness
  • Troubleshoot: Infrastructure IP vNIC Readiness
  • Troubleshoot: Infrastructure IP VMSwitch Readiness
  • Troubleshoot: Intent Virtual Adapter Existence
  • Troubleshoot: Management IP Connection
  • Troubleshoot: Management IP in Infrastructure Subnet
  • Troubleshoot: Management IP Not in Infrastructure Pool
  • Troubleshoot: Management IP Not Overlap Storage Subnet
  • Troubleshoot: Management IP On Correct Adapter
  • Troubleshoot: Network Intent Requirement
  • Troubleshoot: New Node Duplicate IP
  • Troubleshoot: New Node First Adapter Validity
  • Troubleshoot: New Node IP Conflict
  • Troubleshoot: New Node Name and IP Match
  • Troubleshoot: New Node Outside Management Range
  • Troubleshoot: Storage Connectivity Type
  • Troubleshoot: Storage VLAN for 2-Node Switchless

Copilot AI review requested due to automatic review settings February 1, 2026 05:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new set of Azure Local Environment Validator troubleshooting guides (TSGs) focused on networking validators, and wires them into the Networking TSG Table of Contents.

Changes:

  • Added new networking TSG markdown files covering AKS CIDR overlap checks, management/infrastructure IP validations, cluster intent checks, and infra IP connectivity prerequisites.
  • Updated the Networking README Table of Contents to include the new TSGs.
  • Updated a reference link in the Network Adapter Driver Consistency TSG.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-StorageVlan-2Node-Switchless.md New TSG for 2-node switchless storage VLAN requirements.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-StorageConnectivityType.md New TSG for storage connectivity type requirements (Rack Aware vs switchless).
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-NewNode-Outside-MgmtRange.md New TSG for new node management IP not overlapping infra IP pool range.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-NewNode-Name-IP-Match.md New TSG for validating new node hostname ↔ management IP mapping.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-NewNode-IP-Conflict.md New TSG for detecting management IP conflicts with existing nodes/config store.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-NewNode-First-Adapter.md New TSG for ensuring the first management-intent adapter has the management IP.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-NewNode-Duplicate-IP.md New TSG for duplicate management IP detection (including multi-node add).
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-NetworkIntentRequirement.md New TSG for Rack Aware “exactly one storage-only intent” requirement.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-NetworkAdapter-DriverConsistency.md Updated reference link for host network driver requirements.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-MgmtIp-NotIn-InfraPool.md New TSG for ensuring management IPs are outside infra IP pool range.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-MgmtIp-In-InfraSubnet.md New TSG for ensuring management IPs share subnet with infra IP pool.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-MgmtIP-On-Correct-Adapter.md New TSG for validating management IP placement on expected adapter/vManagement vNIC.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-MgmtIP-Not-Overlap-Storage-Subnet.md New TSG for preventing management subnet overlap with storage subnets.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-MgmtIP-Connection.md New TSG for validating WinRM connectivity to management IP and name matching.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-IntentVirtualAdapterExistence.md New TSG for validating Network ATC-created virtual adapters exist and are Up.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-InfraIP-vNIC-Readiness.md New TSG for infra IP test vNIC creation/readiness validation.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-InfraIP-VMSwitch-Readiness.md New TSG for infra IP connectivity VMSwitch readiness/creation requirements.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-InfraIP-IPReadiness.md New TSG for infra IP assignment and gateway reachability validation.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-InfraIP-Hyper-V-Readiness.md New TSG for Hyper-V prerequisite to infra IP connectivity testing.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-InfraIP-DNS-Port-53.md New TSG for infra IP TCP/53 DNS connectivity validation.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-InfraIP-DNS-Client-Readiness.md New TSG for ensuring DNS servers are configured on the management adapter for infra IP tests.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-InfraIP-Azure-Endpoint-Connection.md New TSG for infra IP outbound connectivity checks to Azure endpoints (dynamic validator).
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-Cluster-StorageIntent-Exists.md New TSG for validating storage intent exists before Add-Server.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-Cluster-MgmtIntent-Exists.md New TSG for validating exactly one management intent exists on the cluster.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-Cluster-Intent-Status.md New TSG for validating cluster intent health before Add-Server/Pre-Update.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-AddNode-NetworkATC-Service.md New TSG for NetworkATC feature/service readiness on a new node.
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-AKS-ServiceCidr-IpPool-Overlap.md New TSG for AKS Service CIDR overlap with customer IP pools (warning).
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-AKS-ProxyServer-Cidr-Overlap.md New TSG for proxy server overlap with AKS POD/Service CIDRs (informational).
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-AKS-PodCidr-IpPool-Overlap.md New TSG for AKS POD CIDR overlap with customer IP pools (critical).
TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-AKS-DnsServer-Cidr-Overlap.md New TSG for DNS server overlap with AKS POD/Service CIDRs (informational).
TSG/EnvironmentValidator/Networking/README.md Added TOC entries for the newly introduced TSG documents.
Comments suppressed due to low confidence (1)

TSG/EnvironmentValidator/Networking/Troubleshoot-Network-Test-InfraIP-VMSwitch-Readiness.md:321

  • What: The “Azure Local host network requirements” link includes a versioned ?view=azloc-2601 query parameter.
    Why: This repo’s link guidance avoids version references in URLs so links don’t become stale across releases.
    How: Replace it with the non-versioned Learn URL (remove the view query parameter).
- [Create a virtual switch for Hyper-V](https://learn.microsoft.com/windows-server/virtualization/hyper-v/get-started/create-a-virtual-switch-for-hyper-v-virtual-machines)
- [Azure Local host network requirements](https://learn.microsoft.com/en-us/azure/azure-local/concepts/host-network-requirements?view=azloc-2601)

Fei Fang (KEVIN) and others added 6 commits January 31, 2026 22:02
- Removed 9 inaccessible URLs (HTTP 404) from 13 TSG files
- URLs were located in 'Related Documentation' sections
- Validated all URLs in TSG/EnvironmentValidator/Networking/ directory
- Kept management.azure.com references as they are example endpoints

Files modified:
- Troubleshoot-Network-Test-AKS-DnsServer-Cidr-Overlap.md
- Troubleshoot-Network-Test-AKS-PodCidr-IpPool-Overlap.md
- Troubleshoot-Network-Test-AKS-ServiceCidr-IpPool-Overlap.md
- Troubleshoot-Network-Test-AddNode-NetworkATC-Service.md
- Troubleshoot-Network-Test-IntentVirtualAdapterExistence.md
- Troubleshoot-Network-Test-MgmtIp-In-InfraSubnet.md
- Troubleshoot-Network-Test-MgmtIp-NotIn-InfraPool.md
- Troubleshoot-Network-Test-NetworkIntentRequirement.md
- Troubleshoot-Network-Test-NewNode-Duplicate-IP.md
- Troubleshoot-Network-Test-NewNode-Outside-MgmtRange.md
- Troubleshoot-Network-Test-StorageAdapterReadiness.md
- Troubleshoot-Network-Test-StorageConnectivityType.md
- Troubleshoot-Network-Test-StorageVlan-2Node-Switchless.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Removed ?view=azloc-XXXX query parameters from 31 URLs across 19 files
- Per repo guidelines, URLs should not contain version references
- This prevents links from becoming stale across releases
- Changed URLs now use version-agnostic format

Files modified across multiple TSG categories:
- Deployment (2 files)
- EnvironmentValidator (4 files)
- LCM (1 file)
- Networking (6 files)
- Observability (1 file)
- Security (1 file)
- SolutionExtension (2 files)
- Update (2 files)
- Removed ?view=azloc-XXXX query parameters from 3 URLs in 2 files
- Only modified files in TSG/EnvironmentValidator/Networking/ directory
- Per repo guidelines, URLs should not contain version references

Files modified:
- Troubleshoot-Network-Test-InfraIP-VMSwitch-Readiness.md
- Troubleshoot-Network-Test-MOCStackNetworkPort.md
…StorageConnectivityType.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@AlBurns-MSFT AlBurns-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was interesting how copilot reviewed this large PR. Approved.

@AlBurns-MSFT AlBurns-MSFT merged commit e79b977 into Azure:main Feb 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants