Improvements and corrections to Set-ToolsRepo and additional formatting.#321
Open
calcobia wants to merge 3 commits intoAzure:mainfrom
Open
Improvements and corrections to Set-ToolsRepo and additional formatting.#321calcobia wants to merge 3 commits intoAzure:mainfrom
calcobia wants to merge 3 commits intoAzure:mainfrom
Conversation
Fixed version check by replacing an unsupported ternary conditional operator with the equivalent if statement.
Fixed the path error that would cause the files to not be copied.
calcobia
commented
Apr 18, 2025
Author
calcobia
left a comment
There was a problem hiding this comment.
Before - A simple string comparison
$OldVersion = "10.9.30"
$NewVersion = "10.10.30"
If ($NewVersion -ge $OldVersion) {"New version is newer."} else {"New version is older"}
New version is older
Returns the wrong result.
Now - Semantic version comparison
$OldVersion = [System.Version]::Parse("10.9.30")
$NewVersion = [System.Version]::Parse("10.10.30")
If ($NewVersion -ge $OldVersion) {"New version is newer."} else {"New version is older"}
New version is newer.
Returns the correct result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #
The changes in this PR are as follows:
I have read the contributor guidelines and have completed the following:
AVSAttributeto newly exported functions.