FEAT implement batching for memory interface #1325
Open
+299
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `_SQLITE_MAX_BIND_VARS` constant to handle SQLite limits - implement batching in `get_scores()` for `score_ids` parameter - implement batching in `get_message_pieces()` for `prompt_ids`, `original_values`, `converted_values`, `converted_value_sha256` - implement batching in `get_attack_results()` for `attack_result_ids`, `objective_sha256 parameters` - implement batching in `get_scenario_results()` for `scenario_result_ids` - refactor necessary filter conditions across batched queries - handle empty list edge cases
romanlutz
reviewed
Jan 25, 2026
| batch_param = "prompt_ids" | ||
| batch_values = [str(pi) for pi in prompt_ids] | ||
| batch_column = PromptMemoryEntry.id | ||
| elif original_values and len(original_values) > _SQLITE_MAX_BIND_VARS: |
Contributor
There was a problem hiding this comment.
In the original code, it's possible to filter by all of these, not just one of them. Your changes assume it's at most one (see "elif").
romanlutz
reviewed
Jan 25, 2026
| ) | ||
| if batch_values: | ||
| all_entries: MutableSequence[PromptMemoryEntry] = [] | ||
| for i in range(0, len(batch_values), _SQLITE_MAX_BIND_VARS): |
Contributor
There was a problem hiding this comment.
This code seems to repeat several times. Is there a simple way to make this into a generic method that we can reuse?
romanlutz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #845
Tests and Documentation
Ran test with
Then ran larger test suite with
Documented on code, where needed, as batching stays quite under the hood not sure if it requires changing any documentation or not. But willing to work on documentation part, if I missed something.
Open for upcoming reviews!