[AKS] az aks create/update: Add --enable-container-network-logs parameter
#32700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlotaarvela
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @carlotaarvela, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter enable_container_network_logs |
||
| aks update | cmd aks update added parameter disable_container_network_logs |
||
| aks update | cmd aks update added parameter enable_container_network_logs |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
kairu-ms and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for enabling and disabling Container Network Logs on AKS clusters with Advanced Container Networking Services (ACNS). The feature requires ACNS, monitoring addon, and Cilium network dataplane.
Changes:
- Added
--enable-container-network-logsparameter foraz aks createandaz aks update - Added
--disable-container-network-logsparameter foraz aks update - Automatically enables High Log Scale Mode when container network logs are enabled
- Added validation to ensure prerequisites (ACNS and monitoring addon) are met
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| _params.py | Added parameter definitions for enable/disable container network logs flags |
| _help.py | Added help text for the new parameters and updated high log scale mode description |
| custom.py | Added parameters to aks_create, aks_update, and aks_enable_addons functions; changed enable_syslog and enable_high_log_scale_mode defaults from False to None |
| managed_cluster_decorator.py | Implemented get_container_network_logs() method with validation, modified get_enable_high_log_scale_mode() to auto-enable when CNL is enabled, added update_monitoring_profile_flow_logs() method |
| addonconfiguration.py | Added Microsoft-ContainerNetworkLogs to ContainerInsightsStreams list |
| test_managed_cluster_decorator.py | Added comprehensive unit tests for various container network logs scenarios |
| test_aks_commands.py | Added integration test for creating cluster with container network logs enabled |
| linter_exclusions.yml | Added exclusions for the long parameter names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Jan 27, 2026
Member
There was a problem hiding this comment.
Queued live test to validate the change, test passed!
- test_aks_create_acns_with_flow_logs (failed due to preview feature flag)
- test_aks_create_with_monitoring_aad_auth_msi_with_syslog
- test_aks_create_with_monitoring_aad_auth_uai_with_syslog
- test_aks_enable_monitoring_with_aad_auth_msi_with_syslog
- test_aks_enable_monitoring_with_aad_auth_uai_with_syslog
- test_aks_create_with_monitoring_aad_auth_msi_with_datacollectionsettings_and_otheraddon
- test_aks_create_with_monitoring_aad_auth_with_highlogscale
- test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls_with_highlogscale
carlotaarvela
changed the title
az aks create/update: Add --enable-container-network-logs parameteraz aks create/update: Add --enable-container-network-logs parameter
carlotaarvela
force-pushed
the
feature/container-network-logs
branch
from
bf12a24 to
7254c48
Compare
snguyen64
approved these changes
Jan 27, 2026
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks create
az aks update
Description
Add support for enabling and disabling Container Network Logs on AKS clusters with Advanced Container Networking Services (ACNS).
New parameters:
az aks create --enable-container-network-logs: Enable container network logs during cluster creationaz aks update --enable-container-network-logs: Enable container network logs on an existing clusteraz aks update --disable-container-network-logs: Disable container network logs on an existing clusterContainer Network Logs requires ACNS enabled, monitoring addon enabled, and cilium network dataplane. When enabled, High Log Scale Mode is automatically enabled if not explicitly disabled.
Testing Guide
History Notes
[AKS]
az aks create: Add--enable-container-network-logsparameter to enable container network logs[AKS]
az aks update: Add--enable-container-network-logsand--disable-container-network-logsparametersThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.