{Compute} migrate vmss extension to aaz #32707
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiii99
requested review from
jsntcy,
wangzelin007 and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| compute | sub group compute added |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates az vmss extension commands away from handwritten Compute SDK usage toward AAZ-based implementations.
Changes:
- Reworked VMSS extension operations in
custom.pyto use AAZ VMSS update flow and an AAZ rolling-upgrade command wrapper. - Added generated AAZ command group/code for VMSS extension rolling upgrade.
- Adjusted the VMSS extension scenario test VMSS create parameters (image + SKU) for the test run.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py | Updates the VMSS creation used by VMSS extension scenario tests. |
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Moves VMSS extension delete/show/list/set/upgrade logic toward AAZ-based flows. |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/compute/virtual_machine_scale_set/_extension_rolling_upgrade.py | Adds generated AAZ command to start VMSS extension rolling upgrade. |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/compute/virtual_machine_scale_set/init.py | Exposes the generated VMSS rolling-upgrade command module. |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/compute/virtual_machine_scale_set/__cmd_group.py | Declares the generated AAZ command group for compute virtual machine scale set. |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/compute/init.py | Adds generated AAZ compute package init for command group wiring. |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/compute/__cmd_group.py | Declares the generated AAZ top-level compute command group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/compute/__cmd_group.py
Outdated
Show resolved
Hide resolved
dev dev dev fix ci dev dev
huiii99
force-pushed
the
vmss-extension-migration
branch
from
c3344e1 to
8504de7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vmss extension listaz vmss extension showaz vmss extension deleteaz vmss extension setaz vmss extension upgradeDescription
Migrate
az vmss extensioncommands from hand written sdk to aaz.aaz: Azure/aaz#932
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.