[Maps] az maps account create: Add default value for --sku
#32711
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| maps account create | cmd maps account create update parameter name: removed property required=True |
||
| maps account update | cmd maps account update update parameter name: removed property required=True |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a default value of 'G2' for the --sku parameter in the az maps account create command, making it optional for users since Azure Maps now only supports this SKU for new accounts.
Changes:
- Made
--skuparameter optional by changingrequired=Truetorequired=Falsein parameter definitions - Added default value logic to use 'G2' when
--skuis not specified - Update command remains unaffected as it already handles optional SKU parameter correctly
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/maps/_params.py | Changed --sku parameter from required to optional for maps account commands |
| src/azure-cli/azure/cli/command_modules/maps/custom.py | Added default value 'G2' for SKU in create function when parameter is not provided |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
necusjz
changed the title
az maps account create Add default value for --skuaz maps account create: Add default value for --sku
Member
|
better to have a test case to cover it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az maps account create
Description
Azure Maps now only supports one
--sku(G2) for new accounts. The CLI should not require users to provide a --sku when creating new accounts.Testing Guide
Manually verified default value used when --sku is omitted. No change to test recordings resulting form this change.
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.