Skip to content

Conversation

@stuartleeks
Copy link
Contributor

Add extensions option to the azd devcontainer feature to allow the user to specify extensions to install when installing azd in a dev container

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an extensions option to the azd devcontainer feature, allowing users to specify a comma-separated list of Azure Developer CLI extensions to install automatically when the devcontainer is built.

Key changes:

  • Added extensions configuration option to the devcontainer feature definition
  • Implemented extension installation logic in the install script
  • Added test scenario and test script to verify extension installation functionality

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
ext/devcontainer/src/azd/devcontainer-feature.json Added extensions option (type: string) to feature configuration and bumped version to 0.2.0
ext/devcontainer/src/azd/install.sh Added logic to parse and install comma-separated list of azd extensions
ext/devcontainer/test/azd/scenarios.json Added test scenario configuration with azure.coding-agent extension
ext/devcontainer/test/azd/with_extensions.sh Added test script to verify extension installation
ext/devcontainer/Makefile Added makefile with test target for running devcontainer feature tests

@vhvb1989 vhvb1989 requested a review from danieljurek January 8, 2026 22:51
@vhvb1989
Copy link
Member

vhvb1989 commented Jan 8, 2026

investigating about debian:10 issue... @danieljurek

@vhvb1989
Copy link
Member

Created a fix for the CI tests:
#6494

The OS matrix needed some updates. After that is merged, please rebase @stuartleeks

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity identity issues with no activity label Jan 20, 2026
@vhvb1989
Copy link
Member

still WIP

@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity identity issues with no activity label Jan 20, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity identity issues with no activity and removed no-recent-activity identity issues with no activity labels Jan 27, 2026
@stuartleeks stuartleeks force-pushed the devcontainer-feature-allow-extension-install branch from e6aed96 to 3acbba4 Compare January 27, 2026 09:04
@stuartleeks stuartleeks force-pushed the devcontainer-feature-allow-extension-install branch from 3acbba4 to 51132a4 Compare January 27, 2026 09:05
@stuartleeks
Copy link
Contributor Author

Responded to comments and rebased

# If Azure Developer CLI extensions are requested, loop through and install
if [ -n "${AZD_EXTENSIONS}" ]; then
echo "Installing Azure Developer CLI extensions: ${AZD_EXTENSIONS}"
extensions=(`echo "${AZD_EXTENSIONS}" | tr ',' ' '`)
Copy link
Member

@danieljurek danieljurek Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shell check has a couple recommendations for this line... please fix

Prefer mapfile or read -a to split command output (or quote to avoid splitting).shellcheckSC2207

Use $(...) notation instead of legacy backticks ....shellcheckSC2006

Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks correct, please address shellcheck issues.

Also, I'm going to look into adding shellcheck for our .sh files #6621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants