reusable workflow for linux integrations#445
Merged
davidgamero merged 39 commits intomainfrom Dec 30, 2024
Merged
Conversation
16f65ce to
57fdc8e
Compare
Tatsinnit
approved these changes
Dec 18, 2024
Member
Tatsinnit
left a comment
There was a problem hiding this comment.
❤️🙏 Thank you for the kind ping! The PR is looking great; I’ve added a few thoughts. It might also be worth checking if we can upgrade checkout to v4. Additionally, I noticed that download-artifact is tied to a specific hash, while for others, we only use the version—just an observation to share.
Everything else looks good, and I trust this has been tested against a fork or similar setup.
Thanks so much!
Collaborator
Author
|
once the source of truth for integration tests is moved into a reusable workflow, dependabot will be able to open PRs on theese as well which will resolve many of the version bumps. previously dependabot couldn't upgrade the actions as they were re-generated from the bash file each time |
Tatsinnit
approved these changes
Dec 18, 2024
Tatsinnit
approved these changes
Dec 30, 2024
jaiveerk
approved these changes
Dec 30, 2024
audrastump
pushed a commit
to audrastump/draft
that referenced
this pull request
Jan 2, 2025
Co-authored-by: Tatsinnit <tamishra@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the existing shell script generated integration testing configuration in favor of using reusable github actions and a matrix
Fixes # (issue)
Feature # (details)
Type of change
How Has This Been Tested?
Checklist: