fix(wujie): preserve request headers in fetch interceptor #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fetch interceptor was losing custom headers (like tRPC's trpc-accept) when rewriting URLs. This caused tRPC streaming responses to fail in wujie containers while working correctly in standalone mode. Fix: Use new Request(rewrittenUrl, req) to preserve the original request's complete configuration including headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
trpc-accept) when rewriting URLsRoot Cause
The fetch interceptor was using
window.fetch(rewrittenUrl, init)whereinitmight not contain the complete headers from the originalRequestobject. When tRPC sends requests withtrpc-accept: application/jsonl, this header was lost, causing the server to return traditional JSON instead of streaming JSONL.Fix
Changed from:
To:
This preserves the original request's complete configuration including all headers.