Fix an invalid comment: 95% >> 100%#48
Open
cryptozeny wants to merge 1 commit intoBitzenyCoreDevelopers:z2.0.xfrom
Open
Fix an invalid comment: 95% >> 100%#48cryptozeny wants to merge 1 commit intoBitzenyCoreDevelopers:z2.0.xfrom
cryptozeny wants to merge 1 commit intoBitzenyCoreDevelopers:z2.0.xfrom
Conversation
hitobb
reviewed
Nov 22, 2018
cryptozeny
force-pushed
the
fix-comment-nRuleChangeActivationThreshold
branch
from
4b27aba to
f946c10
Compare
hitobb
approved these changes
Nov 25, 2018
Contributor
hitobb
left a comment
hitobb
left a comment
There was a problem hiding this comment.
LTGM.
This is only for modifying comments, please merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bitzenyPlus#41
I think this
100%is not good for the consensus. We need a discussion about this in near future.Fixing a comment is a trivial thing, but this parameter is important thing.