Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a backend crash in dataset search result processing when OpenSearch returns hits missing _source and/or highlight, by defensively skipping missing fields during mapping.
Changes:
- Add guards when building
contentto handle missing_sourcekeys. - Add guards when building
highlightto handle missinghighlightkeys.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix crash
Change Details (Specifics)
Crash happened if no source or highlight object came back from Opensearch. This PR makes sure the backend catches that.
Related Ticket(s)
https://tracker.nci.nih.gov/browse/INS-1515