Skip to content

Adding bento ref#129

Open
vdonkor wants to merge 19 commits intomainfrom
bento-ref
Open

Adding bento ref#129
vdonkor wants to merge 19 commits intomainfrom
bento-ref

Conversation

@vdonkor
Copy link
Contributor

@vdonkor vdonkor commented May 4, 2023

Modified bento backend

Copy link

@michael-fleming michael-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make the following changes:

  1. for all builds can we use "{{ container_build_path }}" for the path parameter - this will make the code more adaptable
  2. for the frontend build can we delete the commented build steps. we won't be using these going forward so we won't need to keep them to uncomment them
  3. can we add the trivy scanning steps for all of the builds. this should match what is done in the backend build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants