Refactor server config by following its tree structure #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roytak
force-pushed
the
refactor-server-config
branch
2 times, most recently
from
16c7e63 to
447068b
Compare
Roytak
force-pushed
the
refactor-server-config
branch
from
447068b to
25b28db
Compare
michalvasko
requested changes
Nov 18, 2025
Rewrite server configuration. Adds robustness. Rollback support. Readability and scalability improved by utilizing YANG tree structure.
Do not fail when an unsupported key format is encountered. Instead just possibly fail if it were to be used. Fixes CESNET#563
Roytak
force-pushed
the
refactor-server-config
branch
4 times, most recently
from
ff04d1c to
c5f8b94
Compare
michalvasko
requested changes
Nov 21, 2025
Roytak
force-pushed
the
refactor-server-config
branch
3 times, most recently
from
91674e4 to
431989b
Compare
Roytak
force-pushed
the
refactor-server-config
branch
from
431989b to
19a0623
Compare
michalvasko
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
server_config.cfile for better maintainability and scalability.Changes include:
nc_server_config_oper_get_hostkey_algs,nc_server_config_oper_get_kex_algs,nc_server_config_oper_get_encryption_algsandnc_server_config_oper_get_mac_algsnc_server_config_oper_get_supported_ssh_algsandnc_server_config_oper_get_supported_tls_algs