Skip to content

Fix V8 function in Value.h#186

Open
Zosoled wants to merge 1 commit intoCauldronDevelopmentLLC:masterfrom
Zosoled:fix/utf8length
Open

Fix V8 function in Value.h#186
Zosoled wants to merge 1 commit intoCauldronDevelopmentLLC:masterfrom
Zosoled:fix/utf8length

Conversation

@Zosoled
Copy link

@Zosoled Zosoled commented Nov 20, 2025

@jcoffland
Copy link
Member

This is version dependent. Accepting this PR would break builds for other systems. It would have to be wrapped in an ifdef on the v8 version. At what version was this change made? E.g.: https://github.com/CauldronDevelopmentLLC/cbang/blob/master/src/cbang/js/v8/Context.cpp#L54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants