[ENG-10080] Create global_file_updated, global_reviews and node_files_updated subscriptions if missing #11556
+89
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use USER_FILE_UPDATED for group global_file_updated * Use REVIEWS_SUBMISSION_STATUS for group global_reviews
cslzchen
changed the title
cslzchen
commented
Jan 20, 2026
api/subscriptions/views.py
Outdated
Comment on lines
200
to
202
| existing_subscriptions = annotated_obj_qs.filter(legacy_id=subscription_id) | ||
| except ObjectDoesNotExist: | ||
| raise NotFound | ||
| # `global_file_updated` and `global_reviews` should exist by default for every user |
Collaborator
Author
There was a problem hiding this comment.
Just realized ObjectDoesNotExist won't be throw here, need to move the creation part out of the try/except.
| ), | ||
| ) | ||
| existing_subscriptions = annotated_obj_qs.filter(legacy_id=subscription_id) | ||
| if not existing_subscriptions: |
Collaborator
There was a problem hiding this comment.
Suggested change
| if not existing_subscriptions: | |
| if not existing_subscriptions.exists(): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Create global_file_updated, global_reviews and node_files_updated subscriptions if missing
USER_FILE_UPDATEDfor group_global_file_updatedREVIEWS_SUBMISSION_STATUSfor group_global_reviewsNODE_FILE_UPDATEDfor group_node_files_updatedIn addition, added
_is_digest=Truefor newly created OSF users's default subscriptionsChanges
See dfif
Side Effects
N/A
QE Notes
N/A
CE Notes
N/A
Documentation
N/A