Support for rounded bar chart and grid edges#5109
Open
swatiyadav009 wants to merge 1 commit intoChartsOrg:masterfrom
Open
Support for rounded bar chart and grid edges#5109swatiyadav009 wants to merge 1 commit intoChartsOrg:masterfrom
swatiyadav009 wants to merge 1 commit intoChartsOrg:masterfrom
Conversation
Author
|
Please do check my open PR for rounded slices for PieChart as well. |
|
@swatiyadav009 Love this PR, few comments / wishes however:
|
|
I actually don't mind the rounded edges on the bottom but yes the lack of rounding on the highlighted back has been annoying. |
|
@gabors it is popular design when bars in bottom starts without corner radius, and on the top corners is rounded |
|
I made this pull request, both problems above is fixed |
|
Agreed it's better to have options. |
|
@gabors oh, also your wish about implement corner radius in absolute values also there. ✌️ |
|
@crash481 amazing. I can get rid of my fork then 😊 I'll test it out today. Thanks 🙏 |
|
@crash481 on a different subject. How did you add that popup value ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Issue Link 🔗
Goals ⚽
Implementation Details 🚧
Testing Details 🔍