Fix: search bar allowing blank/whitespace queries (closes #196)#263
Open
Audatic07 wants to merge 1 commit intoCircuitVerse:masterfrom
Open
Fix: search bar allowing blank/whitespace queries (closes #196)#263Audatic07 wants to merge 1 commit intoCircuitVerse:masterfrom
Audatic07 wants to merge 1 commit intoCircuitVerse:masterfrom
Conversation
WalkthroughThe submodule pointer for 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents the search bar from accepting empty or whitespace-only queries.
Problem
The search form currently allows blank or whitespace inputs to be submitted, resulting in an empty results page with no feedback.

Ref: #196
Solution
Added an onsubmit function that returns false and prevents submission if the trimmed query is blank.
Testing
Verified that blank queries ("" and " ") are blocked
Verified that valid queries still submit correctly
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.