IPV6 REST geoip created [old]#280
IPV6 REST geoip created [old]#280DhashS wants to merge 2 commits intoCloudBotIRC:developfrom DhashS:develop
Conversation
…ip JSON file, New Geoip command, uses API, ipv4/6 and hostnames work
…ip JSON file, New Geoip command, uses API, ipv4/6 and hostnames work
There was a problem hiding this comment.
Currently this will strip www. from any URL. This may change the result, as www.example.com and example.com could resolve to different IP addresses.
Could you explain your reasoning for doing this?
There was a problem hiding this comment.
My bad, I assumed that socket.gethostbyname would error out on the www. My fault. Please remove this.
There was a problem hiding this comment.
I believe you should be able to edit it, and push to your fork to add the changes to this pull request. Could you do that?
There was a problem hiding this comment.
I deleted that fork, so i have to make a new pull, here it is: #282
|
I think that it really would be preferred if this could be done with an internal process, rather than calling an external API which may or may not continue to function in the future. This does seem like a useful function change though. I think it would be possible to rewrite the current plugin to still use pygeoip, but add support for raw IP addresses and IPv6 however. |
2 participants
moved all the unneeded stuff to disabled_stuff