fix: properly read docker task config from service props & task props#1616
Merged
fix: properly read docker task config from service props & task props#1616
Conversation
Member
Author
|
This PR works in a way that if the config is present in the service or the task, then all values are taken from that config. No merging of e.g. exposed ports is done. This might need to be discussed |
Test Results 49 files ±0 49 suites ±0 1m 27s ⏱️ -17s Results for commit a98e65f. ± Comparison against base commit 29ee9ff. This pull request removes 38 and adds 38 tests. Note that renamed tests count towards both. |
derklaro
approved these changes
May 10, 2025
GiantTreeLP
pushed a commit
to GiantTreeLP/CloudNet
that referenced
this pull request
Jun 7, 2025
…CloudNetService#1616) ### Motivation In CloudNetService#1251 an issue regarding docker configs was resolved. The docker configuration was only read from the service props which is not used by default. The properties are only present in the task and not the service. This PR now fixes the issue and brings support to resolve the config from service & task properties. ### Modification Added a three step process to figure out which configuration to use when resolving properties that might be task / service specific. The order is now: Service -> Task (if present) -> Module Config ### Result The configuration is read correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In #1251 an issue regarding docker configs was resolved. The docker configuration was only read from the service props which is not used by default. The properties are only present in the task and not the service. This PR now fixes the issue and brings support to resolve the config from service & task properties.
Modification
Added a three step process to figure out which configuration to use when resolving properties that might be task / service specific.
The order is now:
Service -> Task (if present) -> Module Config
Result
The configuration is read correctly