London | 26-ITP-Jan | Mohsen Zamani | sprint 2 | Form Controls #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
mohsenzamanist
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jan 21, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted one area where you could improve code further
To answer your question: Different projects can each have their own PR templates on github.
| id="name" | ||
| name="name" | ||
| required | ||
| placeholder="Mohsen Zamani" |
There was a problem hiding this comment.
The specification in the readme has some specific rules about what a valid name should be. Can you find where that is and see if your solution meets it?
Author
There was a problem hiding this comment.
I see your point. I missed this line:
- I require a valid name. I have defined a valid name as a text string of two characters or more.
but resolved it.
LonMcGregor
added
Reviewed
mohsenzamanist
added
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have created a form to collect user's data on T-shirt.
Questions
Does other teams have their own PR template?