Skip to content

Conversation

@mjm-git185
Copy link

@mjm-git185 mjm-git185 commented Jan 14, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

[x ] Use semantic HTML tags to structure the webpage

  • [x ] Create three articles, each including a title, summary, and a link
  • [ x] Check a webpage against a wireframe layout
  • [ x] Test web code using Lighthouse
  • [ x] Use version control by committing often and pushing regularly to GitHub

Acceptance Criteria

  • [ x] Semantic HTML tags are used to structure the webpage.
  • [ x] The page scores 100 for Accessibility in the Lighthouse audit.
  • [ x] The page header includes a title and description.
  • [ x] The articles section has three unique articles, each including a title, summary, and a link.
  • [ x] The page footer is fixed to the bottom of the viewport.
  • [ x] The webpage is styled using a linked .css file.
  • [ x] The webpage is properly committed and pushed to a branch on GitHub.

@netlify
Copy link

netlify bot commented Jan 14, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 6f8282c
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/696e8c4b4d8768000899dd96
😎 Deploy Preview https://deploy-preview-947--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

4 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mjm-git185 mjm-git185 marked this pull request as draft January 14, 2026 14:10
@github-actions

This comment has been minimized.

3 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mjm-git185 mjm-git185 changed the title Glasgow | Jan 26 | Martin McLean | sprint 1 | Wireframe to Web Code #17 Glasgow | ITP January-2026 | Martin McLean | sprint 1 | Wireframe to Web Code Jan 14, 2026
@mjm-git185 mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 15, 2026
@mjm-git185 mjm-git185 marked this pull request as ready for review January 17, 2026 12:55
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 21, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 21, 2026
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's task.

I think the bot is leaving comments because you have some changed files for the form controls sprint inside this one. You can see this if you open the "Files changed" tab at the top of this page. Pull Requests should only contain the files directly relevant to whatever is being developed. Can you figure out how to revert the Form-Controls index back to its original state?

I've left some comments on your Wireframe solution

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good, and it ticks almost all the boxes. The only issue is when I run "lighthouse" in the developer tools on this page, it indicates your are missing something. Can you run that and see if you can resolve the problem?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 21, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants