76% coverage for presentation/core/app_widgets.dart#255
Open
saksham-gt wants to merge 1 commit intodevelopmentfrom
Open
76% coverage for presentation/core/app_widgets.dart#255saksham-gt wants to merge 1 commit intodevelopmentfrom
saksham-gt wants to merge 1 commit intodevelopmentfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## development #255 +/- ##
==============================================
+ Coverage 9.22% 9.72% +0.49%
==============================================
Files 122 122
Lines 3404 3404
==============================================
+ Hits 314 331 +17
+ Misses 3090 3073 -17
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
obella425
reviewed
Sep 10, 2022
| testWidgets('Testing MultiBloc Provider', (tester) async { | ||
| await tester.pumpWidget(initialWidget); | ||
| final multiBlocProvider = find.byType(MultiBlocProvider); | ||
| expect(multiBlocProvider, findsOneWidget); |
There was a problem hiding this comment.
Is it possible to check the providers values instance and validate that all the required blocs are provided
obella425
reviewed
Sep 10, 2022
| import 'package:collaction_app/application/crowdaction/subscription/subscription_bloc.dart'; | ||
| import 'package:collaction_app/application/crowdaction/subscription_status/subscription_status_bloc.dart'; | ||
|
|
||
| class MockAuthBloc extends MockBloc<AuthEvent, AuthState> implements AuthBloc {} |
There was a problem hiding this comment.
We could call this file mocks.dart since it just contains mocks not fixtures
Member
There was a problem hiding this comment.
Agreed.
I saw some mocks in the test utilities file, they don't belong there.
Xazin
force-pushed
the
development
branch
13 times, most recently
from
5be7e86 to
77ff369
Compare
Xazin
force-pushed
the
development
branch
10 times, most recently
from
05db9fc to
1ac5990
Compare
Member
|
@glitchpop-frenzy 👀 |
Xazin
force-pushed
the
development
branch
2 times, most recently
from
8906c8d to
649893f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.