Conversation
|
Don't we also need to set this up on our domains: |
Codecov Report
@@ Coverage Diff @@
## development #343 +/- ##
===============================================
+ Coverage 66.55% 68.78% +2.22%
===============================================
Files 157 157
Lines 4010 4017 +7
===============================================
+ Hits 2669 2763 +94
+ Misses 1341 1254 -87
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Yes we do, we could pass it via CI |
Screen.Recording.2023-01-20.at.19.44.21.mov |
wizlif
requested review from
a team,
Xazin and
phalcorine
and removed request for
a team
Simulator.Screen.Recording.-.iPhone.13.-.2023-01-28.at.21.19.35.mp4 |
wizlif
force-pushed
the
ft/setup-deeplinks
branch
from
b4f049e to
eb1debb
Compare
…logging-auth-repo fix: add manual logging to auth repo
Signed-off-by: Isaac Obella <wizlif@users.noreply.github.com>
Signed-off-by: Isaac Obella <wizlif@users.noreply.github.com>
Signed-off-by: Isaac Obella <wizlif@users.noreply.github.com>
wizlif
force-pushed
the
ft/setup-deeplinks
branch
from
f59cc83 to
25f89ae
Compare
| run: | | ||
| echo "$DEEPLINK_XCCONFIG_CONTENTS" > ios/Flutter/Deeplink.xcconfig | ||
| env: | ||
| DEEPLINK_XCCONFIG_CONTENTS: ${{ secrets.IOS_DEEPLINK_CONFIG }} |
There was a problem hiding this comment.
What do we input here? Different ones depending on Development/Production? DM me on Slack
Xazin
left a comment
Xazin
left a comment
There was a problem hiding this comment.
Not sure if it's rebased properly since I did some changes on development, but shouldn't be any destructive.
|
We need to rebase this, and then we should be able to merge. |
|
Let me cherry pick the major changes |
2 participants
Enables ability to use deep-links to traverse the app routes.
Android
iOs
Android Preview
Screen.Recording.2023-01-17.at.09.08.50.mov
iOs Preview
Screen.Recording.2023-01-17.at.09.23.58.mov
Screen.Recording.2023-01-17.at.09.29.00.mov
Closes #287