This repository was archived by the owner on Mar 29, 2023. It is now read-only.
Open
Conversation
…dynamo repository
[pull request] ignoring samconfig file as per the pull request [pull request] modified naming for the internal interface [pull request] getting rid of useless else statement [pull request] removing dynamodb dependencies in logic [pull request] including mock repository and crowdaction test [pull request] cleaning up some unnecessary lines [pull request] separating repository concerns [pull request] modifying test cases with new repository structure [pull request] changing dynamo repository call from crowdaction main handler [pull request] changing parameters to pass unit test case [pull request] changing crowdactionID from test case [pull request] changing method call for crowdaction test [pull request] fixing parameter issue in crowdaction_test [pull request] testing issue with the args.get(x) call in mock/dynamo repository [pull request] including Mock in each of the function calls from the dynamo repository [pull request] modifying test cases for crowdaction
…ollaction_backend into feat/gh-73/crowdactions
rubenhorn
reviewed
Apr 8, 2022
| Banner string `json:"banner,omitempty"` | ||
| } | ||
|
|
||
| type CrowdactionData struct { |
Collaborator
There was a problem hiding this comment.
CrowdactionData structure should have a field badge_thresholds of type []int.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including the point attributes logic to the Commitments model as well as to reflect the change in the API documentation. This branch is first based from the crowdaction:
https://github.com/CollActionteam/collaction_backend/tree/feat/gh-73/crowdactions
Since I didn't see much more activity for changes to the be done in this crowdaction pull request ( #119 ), I thought it would be better to include the new architecture for this badge threshold task.