Add link_to_subnet and link_to_pod_subnet for aks deployments#1184
Open
nricciar wants to merge 4 commits intoCompositionalIT:masterfrom
Open
Add link_to_subnet and link_to_pod_subnet for aks deployments#1184nricciar wants to merge 4 commits intoCompositionalIT:masterfrom
nricciar wants to merge 4 commits intoCompositionalIT:masterfrom
Conversation
ninjarobot
reviewed
Feb 11, 2025
| @@ -186,6 +186,8 @@ type ManagedCluster = { | |||
| AvailabilityZones: string list | |||
| VirtualNetworkName: ResourceName option | |||
| SubnetName: ResourceName option | |||
Collaborator
There was a problem hiding this comment.
You should replace the existing SubnetName and PodSubnetName with these new properties rather than duplicating them. Otherwise both can be set and it's not clear from the record what will be happen (people will have to reverse engineer the code to see SubnetName takes precedence over Subnet).
Collaborator
|
I have to move this to the next milestone, as I cannot clean this up today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this PR are as follows:
I have read the contributing guidelines and have completed the following:
If I haven't completed any of the tasks above, I include the reasons why here:
Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure: